-
Notifications
You must be signed in to change notification settings - Fork 29
Extend the Allocate to return scores #19
Copy link
Copy link
Open
Labels
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.questionCategorizes issue or PR as a support question.Categorizes issue or PR as a support question.
Metadata
Metadata
Assignees
Labels
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.questionCategorizes issue or PR as a support question.Categorizes issue or PR as a support question.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Now in Interface
Policy, we only return devices when callingAllocate, this is definitely enough for k8s-device-plugin, however, as a kubernetes scheduler developer, I would like to leverage this helper library to build GPU topology aware scheduler plugin, specifically the score extension point which requires a score in prioritizinggo-gpuallocator/gpuallocator/allocator.go
Lines 24 to 32 in 8fc3087
so I wonder whether we can extend the
Allocatemethod return two values, likeWhich then can be reused by other components.
The disadvantage is some policy like
SimplyPolicydoesn't need the score at all.Another option is we'll add another interface like
PriorityPolicywhich helps in prioritizing then the bestEffort policy can implement it. This requires to change theallocator.Allocator()anyway.cc @elezar @klueska
I can help to implement either way if accepted, hope to see your feedbacks.
/kind feature