fix(icms-translate): inject SPOT_ENVIRONMENT into task worker init container#29
Closed
shelleyshen-0 wants to merge 1 commit into
Closed
fix(icms-translate): inject SPOT_ENVIRONMENT into task worker init container#29shelleyshen-0 wants to merge 1 commit into
shelleyshen-0 wants to merge 1 commit into
Conversation
…ntainer Add SpotEnvironment to task LaunchSpecification and wire it into allEnvSet so nvcf_worker_init receives SPOT_ENVIRONMENT=ncp and routes ess-init to the in-cluster ESS. Fixes exit 14 on UPLOAD tasks (NVBug 6180645). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
SpotEnvironmentto the taskLaunchSpecificationtype and wire it through toallEnvSetso the worker init container receivesSPOT_ENVIRONMENTas a Kubernetes env var.The field was present in the NATS message payload but absent from the deserialized struct, so
SPOT_ENVIRONMENTwas never injected and the init container always saw an empty value.Also adds
SpotEnvironmentEnv = "SPOT_ENVIRONMENT"constant tocommon/env.goto match the pattern used by all adjacent env var assignments.Note: the function container translate path (
translate/function/) has the same gap and needs a follow-up fix.Testing
Validated end-to-end:
SPOT_ENVIRONMENTnow appears on the init container and task pods complete successfully.Related Issues
None