Skip to content

Commit f4aac88

Browse files
committed
ci: test on macOS and Node 24
The matrix covered ubuntu with Node 20 and 22, which leaves two gaps. Node 24 is the active LTS; 20 reached end of life in April 2026 and 22 is in maintenance. So the versions being tested were a dead one and a maintenance one, with the release itself published from 22. 24 is added rather than dropping 20, since engines still allows it. More significantly, seven test files contain darwin-gated paths that have never run in CI - ios-project-service, ios-device-debug-service, debug-controller, xcode-select-service, ios-simulator-discovery, host-info and devices-service. On a CLI whose main job is building iOS apps, that was the untested part, and it is the source of the 13-test gap between the local and CI counts. One macOS leg on the LTS covers those without a full cross-product; runners are free on a public repo but the queue time is not. harden-runner only supports the Ubuntu runners, so it is now conditional.
1 parent e8e83e4 commit f4aac88

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/tests.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,26 @@ concurrency:
1414

1515
jobs:
1616
test:
17-
name: Test (Node ${{ matrix.node-version }})
18-
runs-on: ubuntu-latest
17+
name: Test (${{ matrix.os }}, Node ${{ matrix.node-version }})
18+
runs-on: ${{ matrix.os }}
1919

2020
strategy:
2121
fail-fast: false
2222
matrix:
23-
node-version: [ '20.x', '22.x' ]
23+
os: [ ubuntu-latest ]
24+
node-version: [ '20.x', '22.x', '24.x' ]
25+
include:
26+
# A darwin leg is what covers the iOS-specific suites - they are gated
27+
# on the platform and never execute anywhere else. One version is
28+
# enough for that; 24 is the active LTS.
29+
- os: macos-latest
30+
node-version: '24.x'
2431

2532
steps:
2633

2734
- name: Harden the runner (Audit all outbound calls)
35+
# only supported on the Ubuntu runners
36+
if: runner.os == 'Linux'
2837
uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4
2938
with:
3039
egress-policy: audit

0 commit comments

Comments
 (0)