feat(tvos): build Apple TV V8 release variants (#8)

Author: LorenzGit

.github/workflows/build-matrix.yml

@@ -18,6 +18,7 @@ on:
       - 'config.env'
       - 'patches/**'
       - 'scripts/matrix/**'
+      - 'tests/apple-args.py'
       - '.github/workflows/build-matrix.yml'
 
 permissions:
@@ -199,7 +200,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        variant: [arm64-device, arm64-simulator, x64-simulator, arm64-catalyst, x64-catalyst]
+        variant: [arm64-device, arm64-simulator, x64-simulator, arm64-catalyst, x64-catalyst, arm64-tvdevice, arm64-tvsimulator]
     # See the android job for the R2 bucket layout and the missing-secrets
     # fallback; this job mirrors it.
     env:
@@ -217,6 +218,9 @@ jobs:
     steps:
       - uses: actions/checkout@v7
 
+      - name: Check Apple build arguments
+        run: python3 tests/apple-args.py
+
       - name: Check R2 for a prebuilt artifact
         id: cache
         if: env.AWS_ACCESS_KEY_ID != ''

README.md

@@ -40,7 +40,7 @@ from a pinned revision, with the gn args under review, is the point of this repo
 | Platform | Targets | Runner |
 |---|---|---|
 | Android | `arm64-v8a`, `x86_64`, `armeabi-v7a`, `x86` | `ubuntu-24.04` |
-| Apple | `arm64-device`, `arm64-simulator`, `x64-simulator`, `arm64-catalyst`, `x64-catalyst` | `macos-15` |
+| Apple | `arm64-device`, `arm64-simulator`, `x64-simulator`, `arm64-catalyst`, `x64-catalyst`, `arm64-tvdevice`, `arm64-tvsimulator` | `macos-15` |
 
 Each target is its own job with its own checkout. That costs one `gclient sync`
 per job, but the sync is about 6 minutes against 90–145 minutes of compile, so
@@ -173,3 +173,16 @@ most of the reason this repo exists.
 Forked from [Kudo/v8-android-buildscripts](https://github.com/Kudo/v8-android-buildscripts)
 by Kudo Chien, which the original Android build pipeline came from. See
 [LICENSE](LICENSE).
+
+### tvOS source builds
+
+Use `scripts/matrix/build-ios.sh --variant arm64-tvdevice` and
+`--variant arm64-tvsimulator` after the normal iOS source fetch. These use
+the Apple TV SDK and tvOS target triples, with the same deployment minimum
+as iOS. They remain release, jitless builds without WebAssembly. Chromium
+requires `use_blink=true` for its tvOS toolchain; DrumBrake is explicitly
+disabled so that this does not enable an incomplete Wasm configuration.
+The existing iOS and Catalyst arguments are unchanged.
+
+Run `python3 tests/apple-args.py` on macOS to check the emitted GN arguments
+for all seven Apple variants without compiling V8.

scripts/matrix/build-ios.sh

@@ -29,6 +29,7 @@ Usage: $(basename "$0") --variant <variant> [--v8-dir <path>]
 
   --variant           arm64-device | arm64-simulator | x64-simulator
                       | arm64-catalyst | x64-catalyst
+                      | arm64-tvdevice | arm64-tvsimulator
   --cc-wrapper <bin>  Compiler launcher (e.g. sccache), passed to gn as
                       cc_wrapper. Must be on PATH.
 EOF
@@ -54,6 +55,8 @@ case "$VARIANT" in
     x64-simulator)   CPU=x64;   TARGET_ENV=simulator ;;
     arm64-catalyst)  CPU=arm64; TARGET_ENV=catalyst  ;;
     x64-catalyst)    CPU=x64;   TARGET_ENV=catalyst  ;;
+    arm64-tvdevice) CPU=arm64; TARGET_ENV=device ;;
+    arm64-tvsimulator) CPU=arm64; TARGET_ENV=simulator ;;
     *) echo "Invalid --variant '$VARIANT'" >&2; usage >&2; exit 1 ;;
 esac
 
@@ -132,6 +135,13 @@ else
         ios_deployment_target=\"$IOS_DEPLOYMENT_TARGET\""
 fi
 
+# Chromium requires Blink configuration for tvOS even for standalone V8.
+# Disable DrumBrake explicitly: tvOS otherwise enables it independently of
+# v8_enable_webassembly, producing references to omitted Wasm types.
+if [[ "$VARIANT" = arm64-tv* ]]; then
+    GN_ARGS="$GN_ARGS target_platform=\"tvos\" use_blink=true v8_enable_drumbrake=false"
+fi
+
 if [ -n "$CC_WRAPPER" ]; then
     GN_ARGS="$GN_ARGS cc_wrapper=\"$CC_WRAPPER\""
 fi

tests/apple-args.py

@@ -0,0 +1,39 @@
+#!/usr/bin/env python3
+"""Exercise the build entry point, stopping at GN before compiling V8."""
+import os
+from pathlib import Path
+import subprocess
+import tempfile
+import unittest
+
+ROOT = Path(__file__).resolve().parents[1]
+
+class AppleArgs(unittest.TestCase):
+    def args_for(self, variant):
+        with tempfile.TemporaryDirectory() as tmp:
+            directory = Path(tmp)
+            gn = directory / 'gn'
+            gn.write_text('#!/bin/sh\nprintf "%s\\n" "$@" > "$ARGS_CAPTURE"\nexit 77\n')
+            gn.chmod(0o755)
+            env = dict(os.environ, PATH=tmp + ':' + os.environ['PATH'], ARGS_CAPTURE=str(directory / 'args'))
+            result = subprocess.run([str(ROOT / 'scripts/matrix/build-ios.sh'), '--variant', variant, '--v8-dir', tmp], env=env, capture_output=True, text=True)
+            self.assertEqual(result.returncode, 77, result.stderr)
+            return (directory / 'args').read_text()
+
+    def test_tvos_is_release_jitless_and_without_wasm(self):
+        for variant, environment in [('arm64-tvdevice', 'device'), ('arm64-tvsimulator', 'simulator')]:
+            args = self.args_for(variant)
+            for flag in ['target_platform="tvos"', 'use_blink=true', 'v8_enable_drumbrake=false', 'v8_enable_webassembly=false', 'is_debug=false', 'v8_enable_lite_mode=true', f'target_environment="{environment}"']:
+                self.assertIn(flag, args)
+
+    def test_ios_and_catalyst_do_not_receive_tvos_overrides(self):
+        for variant in ['arm64-device', 'arm64-simulator', 'x64-simulator', 'arm64-catalyst', 'x64-catalyst']:
+            args = self.args_for(variant)
+            self.assertNotIn('target_platform=', args)
+            self.assertNotIn('use_blink=', args)
+            self.assertNotIn('v8_enable_drumbrake=', args)
+            self.assertIn('is_debug=false', args)
+            self.assertEqual('v8_enable_lite_mode=true' in args, 'catalyst' not in variant)
+
+if __name__ == '__main__':
+    unittest.main()