Skip to content

Commit ea0d2ff

Browse files
committed
Fix falback logger
1 parent 80a8013 commit ea0d2ff

4 files changed

Lines changed: 11 additions & 15 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@ SECURITY_AUDIT_REPORT.md
1414
*.exe
1515

1616
docs/
17+
.output

api/pkg/di/container.go

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"crypto/tls"
66
"fmt"
7+
"log"
78
"net/http"
89
"os"
910
"strconv"
@@ -1922,8 +1923,8 @@ func (container *Container) initializeUptraceProvider(version string, namespace
19221923

19231924
func logger(skipFrameCount int) telemetry.Logger {
19241925
fields := map[string]string{
1925-
"pid": strconv.Itoa(os.Getpid()),
1926-
"hostname": hostName(),
1926+
"hostname": hostName(),
1927+
string(semconv.DeploymentEnvironmentKey): os.Getenv("ENV"),
19271928
}
19281929

19291930
return telemetry.NewZerologLogger(
@@ -1968,18 +1969,12 @@ func jsonLogger(skipFrameCount int) *zerodriver.Logger {
19681969
}
19691970

19701971
func axiomLogger(skipFrameCount int) *zerodriver.Logger {
1971-
logLevel := zerolog.DebugLevel
1972-
zerolog.SetGlobalLevel(logLevel)
1973-
zerolog.TimestampFieldName = "time"
1974-
zerolog.TimeFieldFormat = time.RFC3339Nano
1975-
19761972
axiomWriter, err := axiomzerolog.New(
1973+
axiomzerolog.SetLevels([]zerolog.Level{zerolog.TraceLevel, zerolog.DebugLevel, zerolog.InfoLevel, zerolog.WarnLevel, zerolog.ErrorLevel, zerolog.PanicLevel, zerolog.FatalLevel, zerolog.NoLevel}),
19771974
axiomzerolog.SetDataset(os.Getenv("AXIOM_DATASET_EVENTS")),
19781975
)
19791976
if err != nil {
1980-
// Fall back to stderr JSON if Axiom is not configured
1981-
zl := zerolog.New(os.Stderr).With().Timestamp().CallerWithSkipFrameCount(skipFrameCount).Logger()
1982-
return &zerodriver.Logger{Logger: &zl}
1977+
log.Fatal(stacktrace.Propagate(err, "cannot create axiom zerolog writer"))
19831978
}
19841979

19851980
zl := zerolog.New(axiomWriter).With().Timestamp().CallerWithSkipFrameCount(skipFrameCount).Logger()

api/pkg/telemetry/gorm_logger.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ func (gorm *gormLogger) LogMode(_ logger.LogLevel) logger.Interface {
2727
return gorm
2828
}
2929

30-
func (gorm *gormLogger) Info(ctx context.Context, s string, i ...interface{}) {
30+
func (gorm *gormLogger) Info(ctx context.Context, s string, i ...any) {
3131
gorm.logger.WithSpan(gorm.tracer.Span(ctx).SpanContext()).Info(fmt.Sprintf(s, i...))
3232
}
3333

34-
func (gorm *gormLogger) Warn(ctx context.Context, s string, i ...interface{}) {
34+
func (gorm *gormLogger) Warn(ctx context.Context, s string, i ...any) {
3535
gorm.logger.WithSpan(gorm.tracer.Span(ctx).SpanContext()).Warn(fmt.Errorf(s, i...))
3636
}
3737

38-
func (gorm *gormLogger) Error(ctx context.Context, s string, i ...interface{}) {
38+
func (gorm *gormLogger) Error(ctx context.Context, s string, i ...any) {
3939
gorm.logger.WithSpan(gorm.tracer.Span(ctx).SpanContext()).Error(fmt.Errorf(s, i...))
4040
}
4141

api/pkg/telemetry/zerolog_logger.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55

66
"github.com/hirosassa/zerodriver"
77
"github.com/rs/zerolog"
8-
semconv "go.opentelemetry.io/otel/semconv/v1.10.0"
8+
semconv "go.opentelemetry.io/otel/semconv/v1.41.0"
99
"go.opentelemetry.io/otel/trace"
1010
)
1111

@@ -34,7 +34,7 @@ func NewZerologLogger(projectID string, fields map[string]string, driver *zerodr
3434
func (logger *zerologLogger) WithService(service string) Logger {
3535
return NewZerologLogger(
3636
logger.projectID,
37-
logger.addField(string(semconv.ServiceNameKey), service),
37+
logger.addField(string(semconv.ServiceNamespaceKey), service),
3838
logger.zerolog,
3939
logger.spanContext,
4040
)

0 commit comments

Comments
 (0)