test: raise vitest test timeout to 30s for slow CI runners#107
Merged
Conversation
The config property tests perform real filesystem I/O on every fast-check iteration. Under v8 coverage instrumentation on the self-hosted runner this exceeds vitest's default 5s per-test timeout, failing `pnpm test:coverage` while plain `pnpm test` passes. https://claude.ai/code/session_01QxQ71Yrf2Cn6zVfM4LY7AR
athena-omt
added
area:infra
pheidon
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_self_hosted_trustedjob runspnpm test:coverage.test/config.property.test.tsruns 40 fast-check iterations per property, each doing real filesystem I/O (mkdtempSync+ YAML write +loadConfig).test/config.property.test.ts:29exceeded vitest's default 5s per-test timeout (Test timed out in 5000ms). This is why plainpnpm testpasses butpnpm test:coveragefails (observed on PR build(deps-dev): Bump fast-check from 4.7.0 to 4.8.0 #104).testTimeout: 30000tovitest.config.ts— a conventional, low-blast-radius change that tolerates slow CI hardware while still catching genuinely hung tests. Coverage thresholds andnumRunsare unchanged.Test plan
pnpm lintpasses on Node 24.14.1pnpm test:coveragepasses on Node 24.14.1 (coverage stable at 75.36% branches)pnpm buildpasseshttps://claude.ai/code/session_01QxQ71Yrf2Cn6zVfM4LY7AR
Generated by Claude Code