Merge pull request #293 from millerds/switch-manifest-image-prep

Move manifest image prep from code to webpack

Author: millerds

src/taskpane/taskpane.ts

@@ -3,15 +3,6 @@
  * See LICENSE in the project root for license information.
  */
 
-// images references in the manifest
-/* eslint-disable no-unused-vars */
-import icon16 from "../../assets/icon-16.png";
-import icon32 from "../../assets/icon-32.png";
-import icon64 from "../../assets/icon-64.png";
-import icon80 from "../../assets/icon-80.png";
-import icon128 from "../../assets/icon-128.png";
-/* eslint-enable no-unused-vars */
-
 /* global console, document, Excel, Office */
 
 // The initialize function must be run each time a new page is loaded

test/end-to-end/src/test-taskpane.ts

@@ -2,15 +2,6 @@ import * as functionsJsonData from "./test-data.json";
 import { pingTestServer, sendTestResults } from "office-addin-test-helpers";
 import { closeWorkbook, sleep } from "./test-helpers";
 
-// images references in the manifest
-/* eslint-disable no-unused-vars */
-import icon16 from "../../assets/icon-16.png";
-import icon32 from "../../assets/icon-32.png";
-import icon64 from "../../assets/icon-64.png";
-import icon80 from "../../assets/icon-80.png";
-import icon128 from "../../assets/icon-128.png";
-/* eslint-enable no-unused-vars */
-
 /* global Office, document, Excel, run */
 const customFunctionsData = (<any>functionsJsonData).functions;
 const port: number = 4201;

test/end-to-end/webpack.config.js

@@ -3,6 +3,7 @@
 const devCerts = require("office-addin-dev-certs");
 const CustomFunctionsMetadataPlugin = require("custom-functions-metadata-plugin");
 const HtmlWebpackPlugin = require("html-webpack-plugin");
+const CopyWebpackPlugin = require("copy-webpack-plugin");
 const path = require("path");
 
 /* global require, module, process, __dirname */
@@ -86,6 +87,14 @@ module.exports = async (env, options) => {
         template: "./test/end-to-end/src/test-commands.html",
         chunks: ["polyfill", "commands"],
       }),
+      new CopyWebpackPlugin({
+        patterns: [
+          {
+            from: "assets/icon-*",
+            to: "assets/[name][ext][query]",
+          },
+        ],
+      }),
     ],
     devServer: {
       static: ["./"],

test/unit/images.d.ts

@@ -81,6 +81,10 @@ module.exports = async (env, options) => {
       }),
       new CopyWebpackPlugin({
         patterns: [
+          {
+            from: "assets/icon-*",
+            to: "assets/[name][ext][query]",
+          },
           {
             from: "manifest*.xml",
             to: "[name]." + buildType + "[ext]",