Skip to content

Commit c66c0ae

Browse files
authored
Merge pull request #283 from OfficeDev/user/millerds/remove-special-start-scripts
Remove extra "start:" scripts from package.json
2 parents 6a347f8 + f011b0b commit c66c0ae

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

.vscode/tasks.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@
3232
"command": "npm",
3333
"args": [
3434
"run",
35-
"start:desktop",
35+
"start",
3636
"--",
37+
"desktop",
3738
"--app",
3839
"excel"
3940
],
@@ -49,8 +50,9 @@
4950
"command": "npm",
5051
"args": [
5152
"run",
52-
"start:desktop",
53+
"start",
5354
"--",
55+
"desktop",
5456
"--app",
5557
"outlook"
5658
],
@@ -66,8 +68,9 @@
6668
"command": "npm",
6769
"args": [
6870
"run",
69-
"start:desktop",
71+
"start",
7072
"--",
73+
"desktop",
7174
"--app",
7275
"powerpoint"
7376
],
@@ -83,8 +86,9 @@
8386
"command": "npm",
8487
"args": [
8588
"run",
86-
"start:desktop",
89+
"start",
8790
"--",
91+
"desktop",
8892
"--app",
8993
"word"
9094
],

convertToSingleHost.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ async function updatePackageJsonForSingleHost(host) {
8989

9090
// Remove scripts that are unrelated to the selected host
9191
Object.keys(content.scripts).forEach(function (key) {
92-
if (key === "convert-to-single-host" || key === "start:desktop:outlook") {
92+
if (key === "convert-to-single-host") {
9393
delete content.scripts[key];
9494
}
9595
});
@@ -195,13 +195,6 @@ async function updatePackageJsonForJSONManifest() {
195195
const data = await readFileAsync(packageJson, "utf8");
196196
let content = JSON.parse(data);
197197

198-
// Remove special start scripts
199-
Object.keys(content.scripts).forEach(function (key) {
200-
if (key.includes("start:")) {
201-
delete content.scripts[key];
202-
}
203-
});
204-
205198
// Change manifest file name extension
206199
content.scripts.start = "office-addin-debugging start manifest.json";
207200
content.scripts.stop = "office-addin-debugging stop manifest.json";

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
"signin": "office-addin-dev-settings m365-account login",
2727
"signout": "office-addin-dev-settings m365-account logout",
2828
"start": "office-addin-debugging start manifest.xml",
29-
"start:desktop": "office-addin-debugging start manifest.xml desktop",
30-
"start:desktop:outlook": "office-addin-debugging start manifest.outlook.xml desktop --app outlook",
31-
"start:web": "office-addin-debugging start manifest.xml web",
3229
"stop": "office-addin-debugging stop manifest.xml",
3330
"test": "npm run test:unit && npm run test:e2e",
3431
"test:e2e": "mocha -r ts-node/register test/end-to-end/*.ts",

0 commit comments

Comments
 (0)