Skip to content

Deduplicate ConversationStateUpdateEvent definition #112

@rbren

Description

@rbren

Problem

ConversationStateUpdateEvent is defined in two places with different shapes:

src/events/types.ts (line ~133):

export interface ConversationStateUpdateEvent extends BaseEvent {
  kind: 'ConversationStateUpdateEvent';
  key: string;
  value: unknown;
  previous_value?: unknown;  // has this field
}

src/conversation/remote-state.ts (line ~18):

export interface ConversationStateUpdateEvent extends Event {
  kind: 'ConversationStateUpdateEvent';
  key: string;
  value: any;  // uses any instead of unknown
  // missing previous_value
}

Different base types (BaseEvent vs Event), different value types (unknown vs any), and the remote-state version is missing previous_value.

Proposed Fix

  • Delete the definition in remote-state.ts
  • Import from events/types.ts instead
  • This is a one-line import change

Impact

Low — small cleanup but eliminates a source of confusion.


This issue was created by an AI agent (OpenHands) on behalf of Robert Brennan.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions