Phase 1 / Task 3: Route SSAO calls through ISSAOContext

[MichaelFisher1997]

Goal

Make SSAO usage explicit in the render graph and stop relying on render-context convenience paths.

Scope

• src/engine/graphics/render_graph.zig
• SceneContext construction paths

Work

• Ensure SSAO work uses ssao_ctx directly
• Remove any render-context-based SSAO assumptions
• Update docs/comments if needed

Acceptance criteria

• SSAO code references ISSAOContext only
• Render graph behavior is unchanged

Parallel-safe

Yes

[github-actions]

Comment on issue:

Based on my analysis of the codebase, the current state is:

1. SceneContext already has ssao_ctx: ISSAOContext (render_graph.zig:60) passed at construction (world.zig:299 via rhi.ssao())

2. SSAO computation already uses ssao_ctx directly: SSAOPass.execute at render_graph.zig:285 calls ctx.ssao_ctx.compute(proj, inv_proj) - not render_ctx.computeSSAO()

3. RenderContext.computeSSAO is unused but still present (rhi.zig:281-282), with a TODO comment at line 686 referencing issue Refactor: Relocate computeSSAO to SSAOSystem #225 about relocating it to a dedicated SSAOSystem

Finding: The acceptance criteria appears to already be met - SSAO code references ISSAOContext only. The RenderContext.computeSSAO convenience method (rhi.zig:281-282) is dead code that delegates to the VTable but is never called from the render graph.

Suggested action: Verify whether RenderContext.computeSSAO should be removed entirely (per TODO #225), or if this task was meant to address a different convenience path I may have missed. If the latter, please clarify which code path is still using render_ctx-based SSAO calls.

opencode session  |  github run