Phase 5 / Task 1: Update constructors and call sites

[MichaelFisher1997]

Goal

Update constructors and app-level call sites to use the new ownership model.

Scope

• src/game/app.zig
• src/world/world.zig
• screen/session setup paths

Work

• Update construction to use the extracted coordinators and interfaces
• Remove stale getters/setters that only exist for old wiring
• Keep startup and shutdown ordering correct

Acceptance criteria

• App boots with the new module boundaries
• No call site depends on removed compatibility paths

Parallel-safe

Yes

[github-actions]

Based on my analysis of the codebase, here's my assessment:

---

Issue Classification: Feature Request / Refactoring Task

Context: This is Task 1 of Phase 5 ("Integration and Polish"), which is itself a subtask of the RHI refactoring epic (#244, now CLOSED). Related tasks include #471 (Task 2: feature toggles) and #472 (Task 3: docs).

Current State of Refactoring:
The extracted coordinators (PipelineManager, RenderPassManager) are already integrated into VulkanContext (see rhi_context_types.zig:197-198). The interfaces IWorld (world.zig:61-117), IScreen (screen.zig:40-87), and EngineContext (screen.zig:17-38) are already defined with vtable patterns.

Observations:

1. Scope is appropriate - Covers app.zig, world.zig, and screen/session setup paths
2. Acceptance criteria are clear - App must boot, no compatibility path dependencies
3. Potential work areas (need verification during implementation):
   • app.zig:engineContext() (line 179) may have direct field access patterns that should use interfaces
   • session.zig (20KB, complex session setup) likely needs review for old wiring
   • WorldStreamer and WorldRenderer field access in world.zig may need interface usage review

Validation:

• This issue is not a duplicate - it's distinct from Phase 5 / Task 2: Move feature toggles into owning systems #471 and Phase 5 / Task 3: Add docs and validation notes #472
• No prior PR specifically addresses this task per available data
• The parent issue Phase 5: Integration and Polish #457 (Phase 5) is CLOSED but the child task Phase 5 / Task 1: Update constructors and call sites #470 remains OPEN, suggesting the task work may not have been completed

Recommendation:
This task requires careful code inspection to identify specific "stale getters/setters" and "compatibility paths." A code review comparing current call sites against the new interface boundaries would be the first step. The task is appropriately scoped but may reveal additional subtasks during implementation.

opencode session  |  github run