Phase 5 / Task 2: Move feature toggles into owning systems

[MichaelFisher1997]

Goal

Move feature toggles closer to the systems and passes they control.

Scope

• src/engine/graphics/render_system.zig
• render pass structs
• related settings paths

Work

• Push disable flags into the relevant pass/system structs
• Keep environment-variable overrides working
• Reduce top-level forwarding fields

Acceptance criteria

• Feature toggles live near the code they affect
• Behavior is unchanged when flags are set

Parallel-safe

Yes

[github-actions]

This is a refactoring task (Feature Request) with clear scope. The current architecture has disable flags centralized in RenderSystem (lines 49-53, 186-189) that forward to SceneContext (lines 77-80) where individual passes check them at execution time (render_graph.zig:232, 256, 282, 375).

Analysis:

• ShadowPass, GPass, SSAOPass, CloudPass need a disabled: bool field
• Existing pattern already exists: BloomPass, TAAPass, FXAAPass, WaterPass each have enabled: bool
• safe_render_mode is different—it controls pass registration, not execution; suggest keeping it at RenderSystem level
• Env var parsing (render_system.zig:64-86) moves into pass init() or remains centralized but writes directly to pass fields
• Remove getters/setters: getDisableShadowDraw, getDisableGPassDraw, getDisableSSAO, getDisableClouds
• Update world.zig:316-319 to read from pass structs instead of RenderSystem

Suggested sub-tasks:

1. Add disabled: bool field to ShadowPass, GPass, SSAOPass, CloudPass
2. Update env var parsing to populate pass fields directly
3. Remove forwarding fields and accessors from RenderSystem
4. Update SceneContext population in world.zig to read from passes

opencode session  |  github run