Skip to content

New skill: perf, numbers or nothing #8

Description

@ms-shashank

Performance is the area where a plausible-sounding change is most likely to do nothing, and where "should be faster" is most likely to be accepted.

Scope

plugins/perf/skills/perf/SKILL.md, tools: full.

  • Measure first, and say what was measured. No optimisation without a starting number and the command that produced it.
  • No claim without a before and after. "This should be faster" is banned wording. If it cannot be measured, say it cannot be measured.
  • Find the actual cost, not the ugly code. The nested loop over four items is not the problem; the query in the loop is.
  • State the size the improvement holds at. A change that helps at 10,000 rows and hurts at 10 is a trade, not a win, and the report should say so.
  • Refuse micro-optimisation without evidence. If the profile does not show it, do not do it.

Acceptance

  • Requires a baseline measurement with the exact command before any change
  • Requires a paired after-measurement, and forbids claiming an improvement without one
  • Requires stating the input size the result holds at
  • Says plainly what to do when something is not measurable, rather than guessing
  • plugin.json and marketplace.json updated

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions