Skip to content

Add Hail batch + translator base refactor#70

Open
illusional wants to merge 12 commits into
masterfrom
add-hail-batch
Open

Add Hail batch + translator base refactor#70
illusional wants to merge 12 commits into
masterfrom
add-hail-batch

Conversation

@illusional

Copy link
Copy Markdown
Member

Relies on #69 being merged, that will cleanup the commit history, otherwise the short history:

Summary:

  • Renamed translate_workflow -> translate_workflow_internal
    • Added namedtuple for naming output type of this method
  • Renamed translate -> translate_workflow
  • Turned @staticmethods into @classmethods for consistency
  • Fixed tests
  • Removed unused params

And added the Hail Batch translator.

@mr-c

mr-c commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Maybe link to https://hail.is/docs/batch/index.html and/or other relevant sites for context?

@junyk junyk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junyk junyk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junyk

junyk commented Jun 9, 2021

Copy link
Copy Markdown
Member

Hi @illusional , the tests failed because anis_assistant in master branch is still calling translator.translate(...) https://github.com/PMCC-BioinformaticsCore/janis-assistant/blob/b51402a90b6f8ea08e1d1b8a261817ebcc6a565e/janis_assistant/management/workflowmanager.py#L1159.
So, I tried to run one of the tests locally with your branch from janis_core and I modified janis_assisstant to call translator.translate_worfklow(...), I ran into another errror:

  File "... /janis-core/janis_core/translations/translationbase.py", line 125, in translate_workflow
    raise Exception(f"Please use the call the '{self.__class__.__name__}.translate_{tool.type.lower().replace('-', '_')}(**kwargs) instead of translate_workflow(**kwargs)")
AttributeError: 'function' object has no attribute 'lower'

Can you look into what changes we should make in janis_assistant to fix this error?
Thanks :)

@junyk junyk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants