From 4d58c9dd71bd4e56f70e4e7c38caea3eeee1b5c8 Mon Sep 17 00:00:00 2001 From: Harsha Raghu Date: Fri, 28 Apr 2023 21:57:53 +0530 Subject: [PATCH 1/2] Update build.gradle --- code/mobile/android/PhoneVR/app/build.gradle | 21 ++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/code/mobile/android/PhoneVR/app/build.gradle b/code/mobile/android/PhoneVR/app/build.gradle index 9e6865bc..97e524fd 100644 --- a/code/mobile/android/PhoneVR/app/build.gradle +++ b/code/mobile/android/PhoneVR/app/build.gradle @@ -11,10 +11,23 @@ keystoreProperties.load(new FileInputStream(keystorePropertiesFile)) android { signingConfigs { releaseconfig { - storeFile file(keystoreProperties['storeFile']) - storePassword System.getenv("Store") - keyAlias keystoreProperties['keyAlias'] - keyPassword System.getenv("Key") + if( System.env.github && System.env.github.event_name && System.env.github.event_name == 'pull_request' ) { +// storeFile(System.env.github.event_name == 'pull_request' ? file("PhoneVRKeyStorePR.jks") : file(keystoreProperties['storeFile'])) +// storePassword(System.env.github.event_name == 'pull_request' ? "test1234" : System.getenv("Store")) +// keyAlias keystoreProperties['keyAlias'] +// keyPassword(System.env.github.event_name == 'pull_request' ? "test1234" : System.getenv("Key")) + // If its a PR Supply a dummy KeySigningConfig + storeFile file("PhoneVRKeyStorePR.jks") + storePassword "test1234" + keyAlias "PhoneVRKeyPR" + keyPassword "test1234" + } + else { + storeFile file(keystoreProperties['storeFile']) + storePassword System.getenv("Store") + keyAlias keystoreProperties['keyAlias'] + keyPassword System.getenv("Key") + } } } compileSdkVersion 33 From 086637fc3d088cac8010fcc34c636517dfb0f709 Mon Sep 17 00:00:00 2001 From: Harsha Raghu Date: Fri, 28 Apr 2023 22:08:42 +0530 Subject: [PATCH 2/2] cleanup --- code/mobile/android/PhoneVR/app/build.gradle | 4 ---- 1 file changed, 4 deletions(-) diff --git a/code/mobile/android/PhoneVR/app/build.gradle b/code/mobile/android/PhoneVR/app/build.gradle index 97e524fd..da3d4587 100644 --- a/code/mobile/android/PhoneVR/app/build.gradle +++ b/code/mobile/android/PhoneVR/app/build.gradle @@ -12,10 +12,6 @@ android { signingConfigs { releaseconfig { if( System.env.github && System.env.github.event_name && System.env.github.event_name == 'pull_request' ) { -// storeFile(System.env.github.event_name == 'pull_request' ? file("PhoneVRKeyStorePR.jks") : file(keystoreProperties['storeFile'])) -// storePassword(System.env.github.event_name == 'pull_request' ? "test1234" : System.getenv("Store")) -// keyAlias keystoreProperties['keyAlias'] -// keyPassword(System.env.github.event_name == 'pull_request' ? "test1234" : System.getenv("Key")) // If its a PR Supply a dummy KeySigningConfig storeFile file("PhoneVRKeyStorePR.jks") storePassword "test1234"