Skip to content

Commit e1f99f8

Browse files
CI: gate the test job on make verify-results, not make test (#30)
1 parent f2260f2 commit e1f99f8

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,14 @@ jobs:
112112
- name: Check out the repo
113113
uses: actions/checkout@v4
114114
- name: Test on PostgreSQL ${{ matrix.pg }}
115-
run: make test
115+
# `make test` alone never fails this step: pgxntool/base.mk (as
116+
# vendored here, 2.2.0) marks its underlying installcheck .IGNORE,
117+
# so a regression exits 0 and only prints the diff. verify-results is
118+
# the real gate -- it runs the same TEST_DEPS chain, then actually
119+
# inspects the pgTAP results (PGXNTOOL_ENABLE_VERIFY_RESULTS defaults
120+
# to yes, PGXNTOOL_VERIFY_RESULTS_MODE to pgtap, matching this
121+
# suite's pgTAP-based tests) and exits non-zero on failure.
122+
run: make verify-results
116123

117124
# A single stable check name for use as a required status check in branch
118125
# protection rules. Matrix jobs produce check names like "🐘 PostgreSQL 14"

0 commit comments

Comments
 (0)