Skip to content

Remove vestigial test/helpers/pgtap-core.sql and pgtap-schema.sql #28

Description

@jnasbyupgrade

`test/helpers/pgtap-core.sql` and `test/helpers/pgtap-schema.sql` (~300KB combined) are vendored copies of pgTAP's own alternate manual-install SQL files (for environments without full extension support). They are not `\i`'d or otherwise referenced anywhere in this repo's own Makefile, SQL, or test infrastructure -- confirmed via:

```
grep -rn "pgtap-core|pgtap-schema" --include=.sql --include=Makefile --include=.mk .
```

which only turns up a self-referential comment inside `pgtap-schema.sql` itself ("Requires pgtap-core.sql"), not an actual include site.

The test suite installs pgtap properly as a real extension (`CREATE EXTENSION pgtap`) everywhere it's needed, so these look like leftovers from an older setup (predating pgtap being installed as a proper extension) rather than something still load-bearing.

Worth removing, pending confirmation nothing depends on them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions