fix(asap-tools): write sketchdb SQL only for a sketchdb arm

Without --prebuilt-output-dir no config runs sketchdb, yet structured
groups got sketchdb SQL files and sql_file entries. They are now
written only with the flag; the ASAPQuery SQL is still rendered, so a
bad entry fails either way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: milindsrivastava1997

asap-tools/experiments/datasets/fake_metric/sketch_bench_workloads.py

@@ -666,20 +666,27 @@ def convert(
     # Structured groups come first: sketchdb runs only those, and results pair
     # across modes by query index, so its queries must be baseline's first.
     groups: Dict[Tuple[bool, int], Dict[str, List[str]]] = {}
+    sketchdb_arm = prebuilt_output_dir is not None
     for entry, q in entries:
         structured = "promql" not in entry
         files = groups.setdefault(
             (not structured, q.interval_secs),
-            {m: [] for m in modes + ([SKETCHDB] if structured else [])},
+            {
+                m: []
+                for m in modes + ([SKETCHDB] if structured and sketchdb_arm else [])
+            },
         )
         comment = f"-- {describe(entry)}\n"
         files[BASELINE].append(comment + raw_sql(q, labels))
         if BASELINE_MV in files:
             files[BASELINE_MV].append(comment + mv_sql(q, views, labels))
         if structured:
-            files[SKETCHDB].append(comment + asapquery_sql(entry))
+            # Rendered either way, so a table without ASAPQuery SQL fails alike.
+            sql = asapquery_sql(entry)
+            if SKETCHDB in files:
+                files[SKETCHDB].append(comment + sql)
     has_structured = any(not promql for promql, _ in groups)
-    if prebuilt_output_dir is not None and not has_structured:
+    if sketchdb_arm and not has_structured:
         raise ValueError(
             f"{table_path}: --prebuilt-output-dir given, but no structured entry "
             "has ASAPQuery SQL for a sketchdb arm"
@@ -756,7 +763,7 @@ def experiment_params(arm_modes: List[str], init_mode: str) -> dict:
             + yaml.safe_dump(experiment_params([mode], mode), sort_keys=False)
         )
         out_paths.append(out_path)
-    if prebuilt_output_dir is not None:
+    if sketchdb_arm:
         prebuilt_output_dir = os.path.abspath(prebuilt_output_dir)
         check_prebuilt_controller_output(prebuilt_output_dir)
         # With baseline in the same experiment, so its results score sketchdb's.

asap-tools/experiments/tests/test_sketch_bench_workloads.py

@@ -372,20 +372,13 @@ def test_writes_config_grouped_by_interval(self):
                         "sketch_bench_views.data_total_value_counter_60s"
                     ),
                 )
+                # No --prebuilt-output-dir, so no sketchdb arm or SQL.
                 structured = groups["interval_60s_structured"]
                 self.assertEqual(
-                    sorted(structured["sql_file"]),
-                    ["baseline", "baseline_mv", "sketchdb"],
+                    sorted(structured["sql_file"]), ["baseline", "baseline_mv"]
                 )
-                # The table's sql as written, with only NOW() substituted.
-                end = "'" + sbw.floored_end_datetime(60) + "'"
-                with open(structured["sql_file"]["sketchdb"]) as f:
-                    self.assertEqual(
-                        f.read(),
-                        "-- quantile(0.99, latency) by (service) over 300s\n"
-                        + e2e["queries"][-1]["sql"].replace("NOW()", end)
-                        + ";\n",
-                    )
+                sql_dir = os.path.dirname(structured["sql_file"]["baseline"])
+                self.assertFalse([n for n in os.listdir(sql_dir) if "sketchdb" in n])
             finally:
                 os.chdir(cwd)
 
@@ -530,6 +523,13 @@ def test_sketchdb_arm_runs_the_structured_queries_on_the_saved_plan(self):
                 self.assertEqual([g["id"] for g in client["sketchdb"]], [0])
                 self.assertEqual(len(client["baseline"][0]["queries"]), 2)
                 self.assertEqual(len(client["sketchdb"][0]["queries"]), 2)
+                # The table's sql as written, with only NOW() substituted.
+                end = "'" + sbw.floored_end_datetime(60) + "'"
+                self.assertEqual(
+                    client["sketchdb"][0]["queries"][0],
+                    "-- quantile(0.99, latency) by (service) over 300s\n"
+                    + structured[0]["sql"].replace("NOW()", end),
+                )
                 # The runner's check that the saved plan covers sketchdb's queries.
                 copy_prebuilt_controller_output(
                     plan,