Skip to content

StepFile cannot Parse because of wrong CultureInfo #215

@2K-d

Description

@2K-d

Context

I have found this problem while executing the testsuite 'Quaver.API.Tests'.

Actual Problem

Logs in LOGS.txt.

There is a problem with parsing of String to Float for the "OFFSET" field.
On my computer when executing the tests the thread current culture is 'fr-FR'. The offset value that is parsed is '-1.40322', it's an invalid format for 'fr-FR', it should be '-1,40322'.

Step to reproduce

  • Change your regional format to 'fr-FR'.
  • Launch testsuite 'Quaver.API.Tests'.

Possible Solution

This can be solved by adding Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;, in the same way that 'OsuBeatmap.cs' does it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions