Skip to content

Improve sniff implementation to be code style agnostic #2

Description

@Rarst

Extracted from #1

Sniff code:

  • $method: you are presuming a code style. Best practice sniffs should be code style agnostic.
    While not very common, this will break on:
public function // some comment
   functionName() {}

Analyzer code:

  • $nextToken in isIncrementingToken() is not code style agnostic.

I am bad with parsers and have no idea how to approach it, so this might take a while. 😅

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions