add/edit menu item broken for types "custom page" and "custom block"

[deepend-tildeclub]

The errors I get in debug mode are:

Notice: Undefined index: menucategory in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 139

Notice: Undefined index: sectioninfo in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 182

Notice: Trying to access array offset on value of type null in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 278

Notice: Trying to access array offset on value of type null in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 279

Notice: Trying to access array offset on value of type null in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 280

Notice: Trying to access array offset on value of type null in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 281

Notice: Undefined index: itemname in /home/mysite/public_html/site/members/include/admin/managemenu/edit_item.php on line 525

The issue I'm having is for example if I am adding a menu item of the "custom page" item type and then I select the page I want the link to be from the other drop down menu.. It always saves as if I selected the middle option. (there are currently 3 options on my custom page drop down).

Similar issue when selecting other menu options as well.. Like "custom block" doesn't save whatever you enter as the code you want.

Not sure which of those errors is most likely to cause the issues or if a few of them are.

[RedDragonWebDesign]

This page has never worked correctly. It just displayed blank in BlueThrust4 before I began my modifications. With my modifications, I got the page to display and I got links working, but I didn't test and fix these other types.

After an hour or two of debugging, it appears the form is not writing some of its data to the database.

To be continued...

[RedDragonWebDesign]

There's a form verification function that is returning true

BlueThrust5/src/members/include/admin/managemenu/_functions.php

Lines 60 to 87 in c1601d2

	function validateMenuItem_CustomPageTypes($pageName, &$formComponents) {
	if($_POST['itemtype'] != $pageName) { return false; }
	global $formObj, $menuItemObj;
	$textAlign = "textalign_".$pageName;
	$targetWindow = "targetwindow_".$pageName;
	$formComponents[$pageName]['validate'] = array("RESTRICT_TO_OPTIONS");
	$formComponents[$textAlign]['validate'] = array("RESTRICT_TO_OPTIONS");
	$formComponents[$targetWindow]['validate'] = array("RESTRICT_TO_OPTIONS");
	$setupFormArgs = array(
	"name" => "console-".$cID."-".$pageName,
	"components" => $formComponents
	);
	$localFormObj = new Form($setupFormArgs);
	if(!$localFormObj->validate()) {
	$formObj->errors = array_merge($formObj->errors, $localFormObj->errors);
	}
	}

and a write to the database function

BlueThrust5/src/members/include/admin/managemenu/_functions.php

Lines 125 to 151 in c1601d2

	function saveMenuItem(&$menuComponents, &$saveObj, $arrDBNames, $dbID, $itemType, $saveAdditionalArgs=array(), $saveType="add") {
	if($_POST['itemtype'] != $itemType) { return false; }
	global $formObj, $menuItemObj;
	foreach($arrDBNames as $componentName => $dbName) {
	$menuComponents[$componentName]['db_name'] = $dbName;
	}
	$saveAdditional = array("menuitem_id" => $menuItemObj->get_info("menuitem_id"));
	$setupFormArgs = array(
	"name" => "console-".$cID."-".$itemType,
	"components" => $menuComponents,
	"saveObject" => $saveObj,
	"saveType" => $saveType,
	"saveAdditional" => array_merge($saveAdditional, $saveAdditionalArgs)
	);
	$localFormObj = new Form($setupFormArgs);
	$localFormObj->save();
	$menuItemObj->update(array("itemtype_id"), array($saveObj->get_info($dbID)));
	}

and also the form itself

BlueThrust5/src/members/include/admin/addmenuitem.php

Lines 445 to 458 in c1601d2

	array(
	"function" => "saveMenuItem",
	"args" => array(
	&$customPageOptionComponents,
	&$menuItemObj->objCustomPage,
	array( "custompage" => "custompage_id",
	"targetwindow_custompage" => "linktarget",
	"textalign_custompage" => "textalign",
	"prefix_custompage" => "prefix"),
	"menucustompage_id",
	"custompage"
	)
	),

The bug is likely in one of these locations. Next step is to start wrapping my head around how these work.

Test case I was using:

[Setman59]

Did this ever get fixed? I tried to install but still can't make a page.

Thanks in advance

[deepend-tildeclub]

Did this ever get fixed? I tried to install but still can't make a page.

I think with the current master it would let you create the page.. But adding the link to the menu is not working as far as I know.

[deepend-tildeclub]

I want to do a big run to figure out all the menu item issues. But not sure where to look since there is so many files relating to how this menu system works. Guess I could just go through each file and find syntax issues or stuff like that maybe to start. But the menu system is one of the main things holding this software back at this point.