From 9839fad9594fee30ad7ca480f106f34ec21e5ef9 Mon Sep 17 00:00:00 2001 From: krissal1234 Date: Fri, 8 May 2026 12:47:45 +0200 Subject: [PATCH 1/2] BUG: Remove duplicate controller call in Flight.__simulate --- rocketpy/simulation/flight.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/rocketpy/simulation/flight.py b/rocketpy/simulation/flight.py index 1443d1d80..e7b0979ba 100644 --- a/rocketpy/simulation/flight.py +++ b/rocketpy/simulation/flight.py @@ -698,15 +698,6 @@ def __simulate(self, verbose): self.__process_sensors_and_controllers_at_current_node(node, phase) - for controller in node._controllers: - controller( - self.t, - self.y_sol, - self.solution, - self.sensors, - self.env, - ) - for parachute in node.parachutes: # Calculate and save pressure signal ( From 52f9086682a4bb2930f9f0a8f11dad0fb30c95ae Mon Sep 17 00:00:00 2001 From: krissal1234 Date: Fri, 8 May 2026 13:07:02 +0200 Subject: [PATCH 2/2] MNT: update CHANGELOG for #959 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 183479c4b..ed4993979 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -89,6 +89,7 @@ Attention: The newest changes should be on top --> - BUG: Duplicate _controllers in Flight.TimeNodes.merge() [#931](https://github.com/RocketPy-Team/RocketPy/pull/931) - BUG: Fix incorrect Jacobian in `only_radial_burn` branch of `SolidMotor.evaluate_geometry` [#935](https://github.com/RocketPy-Team/RocketPy/pull/935) - BUG: Add explicit timeouts to ThrustCurve API requests [#935](https://github.com/RocketPy-Team/RocketPy/pull/935) +- BUG: Remove duplicate controller call in Flight.__simulate [#959](https://github.com/RocketPy-Team/RocketPy/issues/959) ## [v1.11.0] - 2025-11-01