Check now both on ASSERT and CHECK issue #610 (#612)

* Check now both on ASSERT and CHECK issue #610

Added test to check that both ASSERT and CHECK is checked.
Removed filter in constructor.
Added filter to where condition in loop in inspect_tokens

* Check now both on ASSERT and CHECK issue #610

Change the test class to move the ASSERT and CHECK to the 2nd and 3th

* Check now both on ASSERT and CHECK issue #610

Error in test for check

Author: larsip

src/checks/y_check_prefer_is_not.clas.abap

@@ -43,9 +43,6 @@ CLASS y_check_prefer_is_not IMPLEMENTATION.
     settings-threshold = 0.
     settings-documentation = |{ c_docs_path-checks }prefer-is-not-to-not-is.md|.
 
-    relevant_statement_types = VALUE #( ( scan_struc_stmnt_type-if ) ).
-    relevant_structure_types = VALUE #(  ).
-
     set_check_message( 'Prefer IS NOT to NOT IS!' ).
   ENDMETHOD.
 
@@ -56,7 +53,8 @@ CLASS y_check_prefer_is_not IMPLEMENTATION.
                OR str = 'ELSEIF'
                OR str = 'AND'
                OR str = 'OR'
-               OR str = 'ASSERT'.
+               OR str = 'ASSERT'
+               or str = 'CHECK'.
 
       DATA(position) = sy-tabix.
 
@@ -147,4 +145,4 @@ CLASS y_check_prefer_is_not IMPLEMENTATION.
     ENDWHILE.
   ENDMETHOD.
 
-ENDCLASS.
+ENDCLASS.

src/checks/y_check_prefer_is_not.clas.testclasses.abap

@@ -50,6 +50,44 @@ CLASS ltc_not_is_initial IMPLEMENTATION.
 
 ENDCLASS.
 
+CLASS ltc_assert DEFINITION INHERITING FROM ltc_not_is_initial FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
+  PROTECTED SECTION.
+    METHODS get_code_with_issue REDEFINITION.
+ENDCLASS.
+
+CLASS ltc_assert IMPLEMENTATION.
+
+  METHOD get_code_with_issue.
+    result = VALUE #(
+      ( 'REPORT y_example. ' )
+
+      ( ' START-OF-SELECTION.      ' )
+      ( '   DATA(count) = 0. ' )
+      ( '   ASSERT NOT count IS INITIAL. ' )
+    ).
+  ENDMETHOD.
+
+ENDCLASS.
+
+CLASS ltc_check DEFINITION INHERITING FROM ltc_not_is_initial FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
+  PROTECTED SECTION.
+    METHODS get_code_with_issue REDEFINITION.
+ENDCLASS.
+
+CLASS ltc_check IMPLEMENTATION.
+
+  METHOD get_code_with_issue.
+    result = VALUE #(
+      ( 'REPORT y_example. ' )
+
+      ( ' START-OF-SELECTION.      ' )
+      ( '   DATA(count) = 0. ' )
+      ( '   CHECK NOT count IS INITIAL. ' )
+    ).
+  ENDMETHOD.
+
+ENDCLASS.
+
 CLASS ltc_not_contains_pattern DEFINITION INHERITING FROM y_unit_test_base FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
   PROTECTED SECTION.
     METHODS get_cut REDEFINITION.
@@ -698,4 +736,4 @@ CLASS ltc_method_return_structure IMPLEMENTATION.
     ).
   ENDMETHOD.
 
-ENDCLASS.
+ENDCLASS.