From 56b17198542446744bb28cb4e8d02f7f3bcc0328 Mon Sep 17 00:00:00 2001 From: Michal Harakal Date: Sun, 19 Apr 2026 13:24:55 +0200 Subject: [PATCH] Drop js() target from skainet-io-iree-params MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes `./gradlew allTests` configuration failure on develop: the module declared a `js()` target but depends on :skainet-compile-hlo, which does not publish one. Gradle resolution fails with a platform-type variant mismatch (consumer wants `js`, producer only has `wasm`). Wasm targets stay — they use a distinct `wasm` platform attribute that :skainet-compile-hlo does publish. This fix was originally part of PR #525 (commit fdd378e7) but got dropped during the merge; only the first commit landed. Re-applying as a standalone, narrow fix. Closes #527 Co-Authored-By: Claude Opus 4.7 (1M context) --- skainet-io/skainet-io-iree-params/build.gradle.kts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/skainet-io/skainet-io-iree-params/build.gradle.kts b/skainet-io/skainet-io-iree-params/build.gradle.kts index 4095fdf9..2d9eea39 100644 --- a/skainet-io/skainet-io-iree-params/build.gradle.kts +++ b/skainet-io/skainet-io-iree-params/build.gradle.kts @@ -33,10 +33,10 @@ kotlin { linuxX64() linuxArm64() - js { - browser() - } - + // `js()` is intentionally omitted: this module depends on + // :skainet-compile-hlo, which does not publish a JS target. Wasm + // targets are still compatible — they use `wasm` rather than `js` + // platform attributes. See issue #527. @OptIn(ExperimentalWasmDsl::class) wasmJs { browser()