test: remove duplicate scoped-cleanup test coverage

test_get_expired_snapshots_scoped_excludes_shared_snapshots duplicated
test_get_expired_snapshots_scoped_excludes_referenced_snapshots, and
test_delete_expired_snapshots_scoped was a strict subset of
test_delete_expired_snapshots_scoped_to_target_ids. Both pairs were
introduced by separate merge-from-main rounds on this branch.

Signed-off-by: mday-io <mdaytn@gmail.com>

Author: mday-io

tests/core/state_sync/test_state_sync.py

@@ -4369,96 +4369,3 @@ def test_get_expired_snapshots_scoped_to_target_ids(
     )
     assert batch_all is not None
     assert snapshot_b.snapshot_id in batch_all.expired_snapshot_ids
-
-
-def test_get_expired_snapshots_scoped_excludes_shared_snapshots(
-    state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
-) -> None:
-    """Test that scoped cleanup respects protection: snapshots shared with other environments are not deleted."""
-    now_ts = now_timestamp()
-
-    snapshot_a = make_snapshot(
-        SqlModel(
-            name="a",
-            query=parse_one("select a, ds"),
-        ),
-    )
-    snapshot_a.ttl = "in 10 seconds"
-    snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
-    snapshot_a.updated_ts = now_ts - 15000
-
-    snapshot_b = make_snapshot(
-        SqlModel(
-            name="b",
-            query=parse_one("select b, ds"),
-        ),
-    )
-    snapshot_b.ttl = "in 10 seconds"
-    snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING)
-    snapshot_b.updated_ts = now_ts - 15000
-
-    state_sync.push_snapshots([snapshot_a, snapshot_b])
-
-    # Promote snapshot_b to another active environment (prod-like).
-    prod_env = Environment(
-        name="prod",
-        snapshots=[snapshot_b.table_info],
-        start_at="2022-01-01",
-        end_at="2022-01-01",
-        plan_id="test_plan_id",
-        previous_plan_id="test_plan_id",
-    )
-    state_sync.promote(prod_env)
-    state_sync.finalize(prod_env)
-
-    # Even though snapshot_b is in the target set, it should NOT be returned
-    # because it is still referenced by prod_env.
-    batch = state_sync.get_expired_snapshots(
-        ignore_ttl=True,
-        batch_range=ExpiredBatchRange.all_batch_range(),
-        target_snapshot_ids=[snapshot_a.snapshot_id, snapshot_b.snapshot_id],
-    )
-    assert batch is not None
-    # Only snapshot_a is exclusively owned (not referenced by any active environment).
-    assert batch.expired_snapshot_ids == {snapshot_a.snapshot_id}
-    assert [t.snapshot.name for t in batch.cleanup_tasks] == [snapshot_a.name]
-
-
-def test_delete_expired_snapshots_scoped(
-    state_sync: EngineAdapterStateSync, make_snapshot: t.Callable
-) -> None:
-    """Test that delete_expired_snapshots with target_snapshot_ids only deletes scoped snapshots."""
-    now_ts = now_timestamp()
-
-    snapshot_a = make_snapshot(
-        SqlModel(
-            name="a",
-            query=parse_one("select a, ds"),
-        ),
-    )
-    snapshot_a.ttl = "in 10 seconds"
-    snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
-    snapshot_a.updated_ts = now_ts - 15000
-
-    snapshot_b = make_snapshot(
-        SqlModel(
-            name="b",
-            query=parse_one("select b, ds"),
-        ),
-    )
-    snapshot_b.ttl = "in 10 seconds"
-    snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING)
-    snapshot_b.updated_ts = now_ts - 15000
-
-    state_sync.push_snapshots([snapshot_a, snapshot_b])
-
-    # Delete only snapshot_a via scoped cleanup.
-    state_sync.delete_expired_snapshots(
-        batch_range=ExpiredBatchRange.all_batch_range(),
-        ignore_ttl=True,
-        target_snapshot_ids=[snapshot_a.snapshot_id],
-    )
-
-    # snapshot_a should be deleted, snapshot_b should remain.
-    assert not state_sync.get_snapshots([snapshot_a])
-    assert state_sync.get_snapshots([snapshot_b])