Commit c7b003c
committed
fix(db2): do not embed inline COMMENT= in CTAS SQL
Db2 rejects COMMENT= as a table property in CREATE TABLE ... AS ... WITH DATA
statements (SQL0104N). The CTAS path in _create_table was passing table_description
into _build_create_table_exp which unconditionally injects a SchemaCommentProperty.
Fix: pass table_description=None to _build_create_table_exp on the CTAS path.
The description is still applied correctly via a separate COMMENT ON TABLE command
(COMMENT_CREATION_TABLE = COMMENT_COMMAND_ONLY already handles this at line 462).
Fixes: test_ctas_source_columns[db2] CI failure.
Adds: test_ctas_with_table_description unit test to prevent regression.1 parent 0b04c14 commit c7b003c
2 files changed
Lines changed: 37 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
435 | 439 | | |
436 | 440 | | |
437 | 441 | | |
438 | 442 | | |
439 | 443 | | |
440 | 444 | | |
441 | | - | |
| 445 | + | |
442 | 446 | | |
443 | 447 | | |
444 | 448 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
224 | 256 | | |
225 | 257 | | |
226 | 258 | | |
| |||
0 commit comments