feat: Added more tests made by coderabbit

Author: Seluj78

flask_utils/decorators.py

@@ -292,8 +292,9 @@ def wrapper(*args, **kwargs):  # type: ignore
 
             for key in data:
                 if key not in parameters:
-                    if use_error_handlers:
-                        raise BadRequestError(f"Unexpected key: {key}.", f"Expected keys are: {parameters.keys()}")
+                    return _handle_bad_request(
+                        use_error_handlers, f"Unexpected key: {key}.", f"Expected keys are: {parameters.keys()}"
+                    )
 
             for key in data:
                 if key in parameters and not _check_type(data[key], parameters[key], allow_empty):

tests/test_validate_params_with_error_handlers.py

@@ -1,26 +1,78 @@
+import pytest
 from flask import Flask
 
 from flask_utils import validate_params
 
 
-def test_validate_params_without_error_handlers():
-    app = Flask(__name__)
-    app.testing = True
+class TestValidateParamsWithoutErrorHandlers:
+    @pytest.fixture(scope="function")
+    def setup_routes(self):
+        app = Flask(__name__)
+        app.testing = True
 
-    @app.route("/example")
-    @validate_params({"name": str})
-    def example():
-        return "OK", 200
+        @app.route("/example", methods=["POST", "GET"])
+        @validate_params({"name": str})
+        def example():
+            return "OK", 200
 
-    response = app.test_client().get("/example")
-    assert response.status_code == 400
-    assert (
-        response.json["error"]
-        == "The Content-Type header is missing or is not set to application/json, or the JSON body is missing."
-    )
-    assert "success" not in response.json
-    assert "code" not in response.json
-    assert not isinstance(response.json["error"], dict)
+        yield app
 
+    @pytest.fixture(autouse=True)
+    def client(self, setup_routes):
+        yield setup_routes.test_client()
 
-# TODO: Test all possible errors that can be raised by validate_params
+    def test_missing_content_type(self, client):
+        response = client.get("/example")
+        assert response.status_code == 400
+        assert (
+            response.json["error"]
+            == "The Content-Type header is missing or is not set to application/json, or the JSON body is missing."
+        )
+        assert "success" not in response.json
+        assert "code" not in response.json
+        assert not isinstance(response.json["error"], dict)
+
+    def test_malformed_json_body(self, client):
+        response = client.post("/example", data="not a json", headers={"Content-Type": "application/json"})
+        assert response.status_code == 400
+        assert response.json["error"] == "The Json Body is malformed."
+        assert "success" not in response.json
+        assert "code" not in response.json
+        assert not isinstance(response.json["error"], dict)
+
+    def test_json_body_not_dict(self, client):
+        response = client.post("/example", json=["not", "a", "dict"])
+        assert response.status_code == 400
+        assert response.json["error"] == "JSON body must be a dict"
+        assert "success" not in response.json
+        assert "code" not in response.json
+        assert not isinstance(response.json["error"], dict)
+
+    def test_missing_key(self, client, setup_routes):
+        @setup_routes.route("/example2", methods=["POST"])
+        @validate_params({"name": str, "age": int})
+        def example2():
+            return "OK", 200
+
+        response = client.post("/example2", json={"name": "John"})
+        assert response.status_code == 400
+        assert response.json["error"] == "Missing key: age"
+        assert "success" not in response.json
+        assert "code" not in response.json
+        assert not isinstance(response.json["error"], dict)
+
+    def test_unexpected_key(self, client):
+        response = client.post("/example", json={"name": "John", "extra": "value"})
+        assert response.status_code == 400
+        assert response.json["error"] == "Unexpected key: extra."
+        assert "success" not in response.json
+        assert "code" not in response.json
+        assert not isinstance(response.json["error"], dict)
+
+    def test_wrong_type(self, client):
+        response = client.post("/example", json={"name": 123})
+        assert response.status_code == 400
+        assert response.json["error"] == "Wrong type for key name."
+        assert "success" not in response.json
+        assert "code" not in response.json
+        assert not isinstance(response.json["error"], dict)