From f8e08fe0e689da2a3814f4a784ccd14d514cc5c4 Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Wed, 20 May 2026 00:29:26 +0000 Subject: [PATCH 1/4] [Refactor] Simplify mkTmpDir in cli-kit Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `joinPath` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable. --- .jules/refactor.md | 0 packages/cli-kit/src/public/node/fs.ts | 3 +-- 2 files changed, 1 insertion(+), 2 deletions(-) create mode 100644 .jules/refactor.md diff --git a/.jules/refactor.md b/.jules/refactor.md new file mode 100644 index 00000000000..e69de29bb2d diff --git a/packages/cli-kit/src/public/node/fs.ts b/packages/cli-kit/src/public/node/fs.ts index 5948c9f6bb6..72e9060fcae 100644 --- a/packages/cli-kit/src/public/node/fs.ts +++ b/packages/cli-kit/src/public/node/fs.ts @@ -336,8 +336,7 @@ export async function rmdir(path: string, options: RmDirOptions = {}): Promise { outputDebug(outputContent`Creating a temporary directory...`) - const directory = await fsMkdtemp(joinPath(os.tmpdir(), 'tmp-')) - return directory + return fsMkdtemp(joinPath(systemTempDir, 'tmp-')) } /** From ba7992687b02dd18f703d093656ea49528de3b5a Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Wed, 20 May 2026 01:06:40 +0000 Subject: [PATCH 2/4] [Refactor] Simplify mkTmpDir in cli-kit Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `join` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable. --- packages/cli-kit/src/public/node/fs.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli-kit/src/public/node/fs.ts b/packages/cli-kit/src/public/node/fs.ts index 72e9060fcae..8611f611375 100644 --- a/packages/cli-kit/src/public/node/fs.ts +++ b/packages/cli-kit/src/public/node/fs.ts @@ -336,7 +336,7 @@ export async function rmdir(path: string, options: RmDirOptions = {}): Promise { outputDebug(outputContent`Creating a temporary directory...`) - return fsMkdtemp(joinPath(systemTempDir, 'tmp-')) + return fsMkdtemp(join(systemTempDir, 'tmp-')) } /** From 1dfb266f8cf66b721a4d52c374c5a74b242179c7 Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Wed, 20 May 2026 01:34:59 +0000 Subject: [PATCH 3/4] [Refactor] Simplify mkTmpDir in cli-kit Refactor `mkTmpDir` to use `systemTempDir` and `join` for consistency with other temporary directory functions in the same module. Removed unnecessary intermediate variable. From 105f07179fb9801c42c117d73fd552cad1cc5297 Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Wed, 20 May 2026 02:10:57 +0000 Subject: [PATCH 4/4] [Refactor] Simplify mkTmpDir in cli-kit Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `join` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable. --- .jules/refactor.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .jules/refactor.md diff --git a/.jules/refactor.md b/.jules/refactor.md deleted file mode 100644 index e69de29bb2d..00000000000