Enhance JSON review processing script to handle GitHub connection failures

Updated the script to check for GitHub repository availability before creating issues. If the connection fails, files are moved to a 'failed' directory for manual review, improving error handling and user feedback. Adjusted function signatures to accept optional repository parameters.

Author: stephen-rowan

Scripts/process_json_reviews.py

@@ -109,8 +109,11 @@ def format_issue_body(review_data: Dict[str, Any]) -> str:
     return "\n".join(body_lines)
 
 
-def ensure_labels_exist(repo: Any) -> None:
+def ensure_labels_exist(repo: Optional[Any]) -> None:
     """Ensure required labels exist in the repository."""
+    if repo is None:
+        return  # Skip label check if repo is not available
+    
     required_labels = {
         "review": "1f76b4",  # Blue
         "correct": "0e8a16",  # Green
@@ -139,7 +142,7 @@ def ensure_labels_exist(repo: Any) -> None:
             print(f"  ✓ Label already exists: {label_name}")
 
 
-def create_github_issue(repo: Any, review_data: Dict[str, Any]) -> Optional[int]:
+def create_github_issue(repo: Optional[Any], review_data: Dict[str, Any]) -> Optional[int]:
     """Create a GitHub Issue from review data."""
     try:
         # Ensure labels exist
@@ -168,7 +171,7 @@ def create_github_issue(repo: Any, review_data: Dict[str, Any]) -> Optional[int]
         return None
 
 
-def process_json_file(file_path: Path, repo: Any) -> Tuple[bool, Optional[str]]:
+def process_json_file(file_path: Path, repo: Optional[Any]) -> Tuple[bool, Optional[str]]:
     """Process a single JSON review file."""
     try:
         print(f"  Reading file: {file_path}")
@@ -193,7 +196,18 @@ def process_json_file(file_path: Path, repo: Any) -> Tuple[bool, Optional[str]]:
             return False, error_msg
         print(f"  ✓ Validation passed")
 
-        # Create GitHub Issue
+        # Create GitHub Issue (if repo is available)
+        if repo is None:
+            print(f"  ⚠ GitHub connection unavailable, moving file to failed/ for manual review")
+            try:
+                FAILED_DIR.mkdir(parents=True, exist_ok=True)
+                failed_path = FAILED_DIR / file_path.name
+                shutil.move(str(file_path), str(failed_path))
+                print(f"  → Moved to: {failed_path} (will retry when GitHub is available)")
+            except Exception as move_error:
+                print(f"  ⚠ Could not move file: {move_error}", file=sys.stderr)
+            return False, "GitHub connection unavailable"
+        
         print(f"  Creating GitHub Issue...")
         issue_number = create_github_issue(repo, review_data)
         if issue_number is None:
@@ -266,18 +280,6 @@ def main() -> None:
     else:
         print(f"✓ GITHUB_TOKEN is set (length: {len(github_token)})")
 
-    # Initialize GitHub client
-    try:
-        print(f"\nConnecting to GitHub repository: {REPO_OWNER}/{REPO_NAME}")
-        g = Github(github_token)
-        repo = g.get_repo(f"{REPO_OWNER}/{REPO_NAME}")
-        print(f"✓ Successfully connected to repository")
-    except Exception as e:
-        print(f"✗ Error: Failed to connect to GitHub repository: {e}", file=sys.stderr)
-        import traceback
-        traceback.print_exc()
-        sys.exit(2)
-    
     # Ensure directories exist
     print(f"\nChecking directories...")
     os.makedirs(REVIEWS_DIR, exist_ok=True)
@@ -303,6 +305,21 @@ def main() -> None:
         print("Exiting successfully (no files to process)")
         return
 
+    # Only connect to GitHub if we have files to process
+    repo = None
+    print(f"\nConnecting to GitHub repository: {REPO_OWNER}/{REPO_NAME}")
+    try:
+        g = Github(github_token)
+        repo = g.get_repo(f"{REPO_OWNER}/{REPO_NAME}")
+        print(f"✓ Successfully connected to repository")
+    except Exception as e:
+        print(f"✗ Error: Failed to connect to GitHub repository: {e}", file=sys.stderr)
+        print(f"⚠ Warning: Cannot connect to GitHub. Files will be moved to failed/ for manual review.")
+        import traceback
+        traceback.print_exc()
+        # Don't exit - continue to handle files locally
+        repo = None
+    
     # Process each file
     processed_count = 0
     failed_count = 0