cleanup todos

Author: Skycoder42

doc/setup.dox

@@ -254,6 +254,10 @@ Currently known:)
 - Apple Keychain (macOs and iOs only)
 - Plain (An **unsecure** fallback implementation that works on any platform)
 
+@note Typically the plugin is expected to in the `$QT_INSTALL_PLUGINS/keystores` folder. If you
+have the plugins elsewhere, use the `PLUGIN_KEYSTORES_PATH` environment variable to specify
+additional paths, seperated by the system path seperator (`:` on unix, `;` on windows)
+
 More keystores can be added by creating a custom KeyStorePlugin
 
 @accessors{

src/datasync/accountmanager.h

@@ -134,7 +134,7 @@ class Q_DATASYNC_EXPORT AccountManager : public QObject
 	//! @copydoc exportAccountTrusted(bool, const QString &, const std::function<void(QJsonObject)> &, const std::function<void(QString)> &)
 	void exportAccountTrusted(bool includeServer, const QString &password, const std::function<void(QByteArray)> &completedFn, const std::function<void(QString)> &errorFn = {});
 	//! Import an account from the given untrusted export data
-	void importAccount(const QJsonObject &importData, const std::function<void(bool,QString)> &completedFn, bool keepData = false); //NOTE doc: completed does not mean accepted from peer, just valid import
+	void importAccount(const QJsonObject &importData, const std::function<void(bool,QString)> &completedFn, bool keepData = false);
 	//! @copydoc importAccount(const QJsonObject &, const std::function<void(bool,QString)> &, bool)
 	void importAccount(const QByteArray &importData, const std::function<void(bool,QString)> &completedFn, bool keepData = false);
 	//! Import an account from the given trusted export data

src/datasync/datastore.cpp

@@ -148,7 +148,6 @@ QVariantList DataStore::search(int metaTypeId, const QString &query, SearchMode
 
 void DataStore::iterate(int metaTypeId, const function<bool (QVariant)> &iterator) const
 {
-	//TODO make atomic
 	auto keyList = keys(metaTypeId);
 	foreach(auto key, keyList) {
 		if(!iterator(load(metaTypeId, key)))

src/datasync/qtdatasync_helpertypes.h

@@ -22,7 +22,6 @@ struct is_object : public std::false_type {};
 template <class T>
 struct is_object<T*> : public std::is_base_of<QObject, T> {};
 
-//NOTE c++17 disjunction
 template <typename T>
 struct is_storable : public is_gadget<T> {};
 

src/datasync/setup.cpp

@@ -71,7 +71,6 @@ bool Setup::keystoreAvailable(const QString &provider)
 
 QString Setup::defaultKeystoreProvider()
 {
-	//NOTE add envvar to doc
 #if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
 	auto prefered = qEnvironmentVariable("QTDATASYNC_KEYSTORE");
 #else

src/datasync/setup.h

@@ -68,7 +68,6 @@ class Q_DATASYNC_EXPORT RemoteConfig
 	Q_PROPERTY(HeaderHash headers READ headers WRITE setHeaders)
 	//! The keep alive timeout to be used to send pings to the server
 	Q_PROPERTY(int keepaliveTimeout READ keepaliveTimeout WRITE setKeepaliveTimeout)
-	//TODO add ssl config -> make serializing hard...
 
 public:
 	//! Typedef for a hash of additional HTTP headers

tools/appserver/app.cpp

@@ -208,7 +208,7 @@ void App::onSignal(int signal)
 QString App::findConfig() const
 {
 #if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
-	auto configPath = qEnvironmentVariable("QDSAPP_CONFIG_FILE");//NOTE document
+	auto configPath = qEnvironmentVariable("QDSAPP_CONFIG_FILE");
 #else
 	auto configPath = QString::fromUtf8(qgetenv("QDSAPP_CONFIG_FILE"));
 #endif
@@ -217,7 +217,7 @@ QString App::findConfig() const
 
 	//if not set: empty list
 #if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
-	auto tmpPaths = qEnvironmentVariable("QDSAPP_CONFIG_PATH").split(QDir::listSeparator(), QString::SkipEmptyParts);//NOTE document
+	auto tmpPaths = qEnvironmentVariable("QDSAPP_CONFIG_PATH").split(QDir::listSeparator(), QString::SkipEmptyParts);
 #else
 	auto tmpPaths = QString::fromUtf8(qgetenv("QDSAPP_CONFIG_PATH")).split(QDir::listSeparator(), QString::SkipEmptyParts);
 #endif