Skip to content

Commit 4a41695

Browse files
committed
Simplify dynamic-sbom-inference's summary output
Drop reactor-member "skippedCovered" lines from the per-line table - they're implied by their parent's line already showing up, and the aggregate count in the summary still reports them. Also drop the "across N build root(s)" total from the summary line: it counted every candidate directory visited, including reactor members that aren't independent build roots, which overstated how many actually exist.
1 parent 4359368 commit 4a41695

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

src/commands/manifest/output-manifest-dynamic-sbom-inference.mts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@ import type { RecursiveManifestOutcome } from './generate-recursive-manifests.mt
77
import type { CResult, OutputKind } from '../../types.mts'
88

99
function renderTable(outcomes: readonly RecursiveManifestOutcome[]): string {
10+
// A reactor member covered by its parent's own facts run is implied by that
11+
// parent's line already showing up above it; listing it again here is just
12+
// noise, and the aggregate count still shows up in summarize().
1013
return outcomes
14+
.filter(o => o.status !== 'skippedCovered')
1115
.map(
1216
o =>
1317
`- ${o.dir} (${o.ecosystem}): ${o.status}${o.factsPath ? ` -> ${o.factsPath}` : ''}`,
@@ -25,9 +29,8 @@ function summarize(outcomes: readonly RecursiveManifestOutcome[]): string {
2529
o => o.status === 'skippedDisabled',
2630
).length
2731
const empty = outcomes.filter(o => o.status === 'empty').length
28-
const roots = new Set(outcomes.map(o => o.dir)).size
2932
return (
30-
`Generated ${generated} Socket facts file(s) across ${roots} build root(s); ` +
33+
`Generated ${generated} Socket facts file(s); ` +
3134
`${failed} failed, ${skippedCovered} skipped (already covered), ` +
3235
`${skippedDisabled} skipped (disabled/pom), ${empty} empty.`
3336
)

0 commit comments

Comments
 (0)