chore(scan create): trim redundant comments and restore export order

Match the sibling `cmd-scan-*` convention of placing
`export const cmd*` immediately before `async function run`, and drop
comments that restated the code rather than explaining non-obvious
*why*. The one remaining comment on the misuse check keeps the
meow/yargs-parser coercion detail, which isn't derivable from reading
the code.

Author: jdalton

packages/cli/src/commands/scan/cmd-scan-create.mts

@@ -202,10 +202,6 @@ const generalFlags: MeowFlags = {
   },
 }
 
-// Scan argv for `--default-branch=<non-bool-string>` (both kebab-case
-// and yargs-parser's camelCase expansion). The flag is declared boolean,
-// so meow coerces `--default-branch=main` to `true` and discards "main"
-// — silently leaving the scan without a branch tag.
 const DEFAULT_BRANCH_PREFIXES = ['--default-branch=', '--defaultBranch=']
 
 function findDefaultBranchValueMisuse(
@@ -226,6 +222,12 @@ function findDefaultBranchValueMisuse(
   return undefined
 }
 
+export const cmdScanCreate = {
+  description,
+  hidden,
+  run,
+}
+
 async function run(
   argv: string[] | readonly string[],
   importMeta: ImportMeta,
@@ -290,18 +292,13 @@ async function run(
   `,
   }
 
-  // Detect the common `--default-branch=main` misuse before meow parses.
-  // `--default-branch` is a boolean — meow/yargs-parser treats
-  // `--default-branch=main` as `defaultBranch=true` and silently drops
-  // the "main" portion, so the user's scan gets tagged without the
-  // intended branch name and doesn't appear in the Main/PR dashboard
-  // tabs. Fail fast with a suggestion toward the correct form.
+  // `--default-branch` is declared boolean, so meow/yargs-parser
+  // coerces `--default-branch=main` to `defaultBranch=true` and drops
+  // "main" silently — the resulting scan is untagged and invisible in
+  // the Main/PR dashboard tabs. Catch that shape before meow parses.
   const defaultBranchMisuse = findDefaultBranchValueMisuse(argv)
   if (defaultBranchMisuse) {
     const { prefix, value } = defaultBranchMisuse
-    // Strip the trailing `=` from the matched prefix when naming the
-    // canonical flag in the suggestion — users should always be told
-    // to use the kebab-case form.
     logger.fail(
       `"${prefix}${value}" looks like you meant the branch name "${value}".\n--default-branch is a boolean flag; pass the branch name with --branch instead:\n  socket scan create --branch ${value} --default-branch`,
     )
@@ -717,9 +714,3 @@ async function run(
     workspace: (workspace && String(workspace)) || '',
   })
 }
-
-export const cmdScanCreate = {
-  description,
-  hidden,
-  run,
-}

packages/cli/test/unit/commands/scan/cmd-scan-create.test.mts

@@ -1368,10 +1368,6 @@ describe('cmd-scan-create', () => {
     })
 
     describe('--default-branch misuse detection', () => {
-      // --default-branch is a boolean flag; meow silently discards the
-      // `=<value>` portion on `--default-branch=<name>`. Catch that
-      // pattern before meow parses so users get a clear error pointing
-      // at the right shape (`--branch <name> --default-branch`).
       it('fails when --default-branch=<name> is passed with a branch name', async () => {
         await cmdScanCreate.run(
           ['--org', 'test-org', '--default-branch=main', '.'],
@@ -1392,8 +1388,6 @@ describe('cmd-scan-create', () => {
       })
 
       it('also catches the camelCase --defaultBranch=<name> variant', async () => {
-        // yargs-parser expands camelCase, so users can type either
-        // form from the shell. See Cursor bugbot feedback on PR #1230.
         await cmdScanCreate.run(
           ['--org', 'test-org', '--defaultBranch=main', '.'],
           importMeta,
@@ -1405,8 +1399,6 @@ describe('cmd-scan-create', () => {
         expect(mockLogger.fail).toHaveBeenCalledWith(
           expect.stringContaining('looks like you meant the branch name "main"'),
         )
-        // Error quotes the exact form the user typed so there's no
-        // confusion about whether the error applies to their input.
         expect(mockLogger.fail).toHaveBeenCalledWith(
           expect.stringContaining('"--defaultBranch=main"'),
         )
@@ -1433,7 +1425,6 @@ describe('cmd-scan-create', () => {
           context,
         )
 
-        // meow parses the flag normally and flows through to handleCreateNewScan.
         expect(mockLogger.fail).not.toHaveBeenCalledWith(
           expect.stringContaining('looks like you meant the branch name'),
         )