Commit a4005db
committed
refactor(test): use crypto.randomUUID for temp directories
Replace Date.now() + Math.random() patterns with Node.js built-in
crypto.randomUUID() for cleaner and more robust unique directory
generation in tests. Fixes race condition in CI where tests running
in parallel could share the same directory name.
Changes:
- test/unit/fs-sync.test.ts: Use randomUUID and sequential execution
- test/unit/dlx.test.ts: Use randomUUID for test DLX directory
- test/unit/utils/temp-file-helper.mts: Use randomUUID in createTempDir and withTempFile
Benefits:
- Fixes ENOENT errors in CI from parallel test interference
- More straightforward than Date.now() + random string concatenation
- Guaranteed uniqueness with standard UUID format
- Sequential execution prevents shared variable race conditions
- Cleaner, more readable code1 parent dadd4e3 commit a4005db
File tree
3 files changed
+8
-5
lines changed- test/unit
- utils
3 files changed
+8
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
48 | | - | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
72 | | - | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| |||
130 | 131 | | |
131 | 132 | | |
132 | 133 | | |
133 | | - | |
| 134 | + | |
134 | 135 | | |
135 | 136 | | |
136 | 137 | | |
| |||
0 commit comments