Commit b25aebf
test(bun): keep uuid-derived values out of assertion messages for CodeQL
GitHub's default CodeQL setup raised eight rust/cleartext-logging alerts on
the new bun tests: its name-based heuristic treats any value flowing from a
`uuid`-named binding (a loop variable, a tuple holding `dep.uuid_h`, the
`other_uuid` fixture) as sensitive when it reaches a panic/assert message.
The values are patch identifiers in test fixtures, not secrets, but the
repo keeps the check green on PRs, so the messages now describe the failed
condition without interpolating those values and the uuid is bound apart
from the vendor envelope it was paired with. No assertion got weaker: each
still checks the same condition and prints the same envelope/lock context.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>1 parent 9772549 commit b25aebf
2 files changed
Lines changed: 20 additions & 9 deletions
File tree
- crates
- socket-patch-cli/tests
- socket-patch-core/src/patch/redirect
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1011 | 1011 | | |
1012 | 1012 | | |
1013 | 1013 | | |
1014 | | - | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
1015 | 1018 | | |
1016 | | - | |
1017 | | - | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
1018 | 1022 | | |
1019 | 1023 | | |
1020 | 1024 | | |
| |||
1122 | 1126 | | |
1123 | 1127 | | |
1124 | 1128 | | |
1125 | | - | |
| 1129 | + | |
1126 | 1130 | | |
1127 | 1131 | | |
1128 | 1132 | | |
| |||
1269 | 1273 | | |
1270 | 1274 | | |
1271 | 1275 | | |
1272 | | - | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
1273 | 1284 | | |
1274 | 1285 | | |
1275 | 1286 | | |
1276 | 1287 | | |
1277 | | - | |
| 1288 | + | |
1278 | 1289 | | |
1279 | 1290 | | |
1280 | 1291 | | |
| |||
1284 | 1295 | | |
1285 | 1296 | | |
1286 | 1297 | | |
1287 | | - | |
| 1298 | + | |
1288 | 1299 | | |
1289 | 1300 | | |
1290 | 1301 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1296 | 1296 | | |
1297 | 1297 | | |
1298 | 1298 | | |
1299 | | - | |
1300 | | - | |
| 1299 | + | |
| 1300 | + | |
1301 | 1301 | | |
1302 | 1302 | | |
1303 | 1303 | | |
| |||
0 commit comments