Skip to content

Commit d391f14

Browse files
committed
Drop unrelated formatting from the pipx fix
The previous commit ran rustfmt over the whole workspace, which reformatted 126 files the fix doesn't touch. Restore them to main so the PR only carries the pipx discovery change and its tests. Assisted-by: Claude Code:claude-opus-5-5
1 parent 7376eb5 commit d391f14

127 files changed

Lines changed: 756 additions & 2048 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎crates/socket-patch-cli/src/commands/apply.rs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ use clap::Args;
22
use socket_patch_core::api::blob_fetcher::get_missing_blobs;
33
use socket_patch_core::api::client::{get_api_client_with_overrides, ApiClient};
44
use socket_patch_core::crawlers::ruby_crawler::config_path_ignored_warning;
5-
use socket_patch_core::crawlers::{detect_npm_pkg_manager, Ecosystem, NpmPkgManager, RubyCrawler};
5+
use socket_patch_core::crawlers::{
6+
detect_npm_pkg_manager, Ecosystem, NpmPkgManager, RubyCrawler,
7+
};
68
use socket_patch_core::manifest::operations::read_manifest;
79
use socket_patch_core::manifest::schema::{PatchFileInfo, PatchManifest, PatchRecord};
810
use socket_patch_core::patch::apply::{

‎crates/socket-patch-cli/src/commands/list.rs‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -431,10 +431,7 @@ pub async fn run(args: ListArgs) -> i32 {
431431
detail: detail.clone(),
432432
});
433433
} else if !args.common.silent {
434-
eprintln!(
435-
"Warning: {}",
436-
crate::commands::rollback::capitalize_first(detail)
437-
);
434+
eprintln!("Warning: {}", crate::commands::rollback::capitalize_first(detail));
438435
}
439436
}
440437
let vendor_state = crate::commands::vendor_state_lenient(&loaded.vendor, args.common.silent);
@@ -776,18 +773,12 @@ mod tests {
776773
let listings = HostedListing::from_pins(
777774
&[
778775
pin("pkg:npm/minimist@1.2.2", &record.uuid),
779-
pin(
780-
"pkg:npm/other@1.0.0",
781-
"33333333-3333-4333-8333-333333333333",
782-
),
776+
pin("pkg:npm/other@1.0.0", "33333333-3333-4333-8333-333333333333"),
783777
],
784778
Some(&legacy),
785779
);
786780
assert_eq!(listings[0].record, record);
787-
assert_eq!(
788-
listings[1].record.uuid,
789-
"33333333-3333-4333-8333-333333333333"
790-
);
781+
assert_eq!(listings[1].record.uuid, "33333333-3333-4333-8333-333333333333");
791782
assert!(listings[1].record.vulnerabilities.is_empty());
792783
assert_eq!(listings[1].lockfiles, vec!["yarn.lock".to_string()]);
793784
}

‎crates/socket-patch-cli/src/commands/mod.rs‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
pub mod apply;
22
pub(crate) mod bun_preflight;
3-
pub(crate) mod composer_hints;
43
pub(crate) mod context;
4+
pub(crate) mod composer_hints;
55
pub(crate) mod fetch_stage;
66
pub mod get;
77
pub mod hosted_bundle;
88
pub mod list;
99
pub(crate) mod lock_cli;
1010
pub mod remove;
1111
pub mod repair;
12+
pub(crate) mod vendored_backend;
1213
pub mod rollback;
1314
pub mod scan;
1415
pub mod update;
1516
pub mod vendor;
16-
pub(crate) mod vendored_backend;
1717
pub mod vex;
1818
pub(crate) mod vex_consumed;
1919
pub(crate) mod vex_sources;
@@ -97,11 +97,9 @@ pub(crate) async fn hosted_state_from_lockfiles(
9797
common: &crate::args::GlobalArgs,
9898
root: &Path,
9999
) -> socket_patch_core::patch::redirect::RedirectState {
100-
hosted_state_from_pins(
101-
&socket_patch_core::patch::redirect::upstream::HostedPin::all(
102-
&discover_wiring(common, root).await,
103-
),
104-
)
100+
hosted_state_from_pins(&socket_patch_core::patch::redirect::upstream::HostedPin::all(
101+
&discover_wiring(common, root).await,
102+
))
105103
}
106104

107105
/// [`hosted_state_from_lockfiles`] over already-discovered pins. A purl
@@ -111,17 +109,18 @@ pub(crate) fn hosted_state_from_pins(
111109
) -> socket_patch_core::patch::redirect::RedirectState {
112110
let mut state = socket_patch_core::patch::redirect::RedirectState::new();
113111
for pin in pins {
114-
state.records.entry(pin.purl.clone()).or_insert_with(|| {
115-
socket_patch_core::manifest::schema::PatchRecord {
112+
state
113+
.records
114+
.entry(pin.purl.clone())
115+
.or_insert_with(|| socket_patch_core::manifest::schema::PatchRecord {
116116
uuid: pin.uuid.clone(),
117117
exported_at: String::new(),
118118
files: Default::default(),
119119
vulnerabilities: Default::default(),
120120
description: String::new(),
121121
license: String::new(),
122122
tier: String::new(),
123-
}
124-
});
123+
});
125124
}
126125
state
127126
}
@@ -148,3 +147,4 @@ pub(crate) fn vendor_state_lenient(
148147
}
149148
}
150149
}
150+

‎crates/socket-patch-cli/src/commands/remove.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ use super::rollback::{
1717
pin_before_hash_blobs, rollback_patches_inner, run_hosted_leg, sweep_failure,
1818
sweep_unused_artifacts, HostedLegOutcome, InnerSelection,
1919
};
20+
use crate::commands::vendored_backend::{RevertedEntry, VendorRevertStep, VendoredBackend};
2021
use crate::args::{apply_env_toggles, GlobalArgs};
2122
use crate::commands::lock_cli::acquire_or_emit;
22-
use crate::commands::vendored_backend::{RevertedEntry, VendorRevertStep, VendoredBackend};
2323
use crate::json_envelope::{Command, Envelope, EnvelopeError, PatchAction, PatchEvent, Status};
2424
use crate::ui::plural;
2525

‎crates/socket-patch-cli/src/commands/rollback.rs‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ use socket_patch_core::manifest::operations::{
1010
};
1111
use socket_patch_core::manifest::schema::{PatchFileInfo, PatchManifest, PatchRecord};
1212
use socket_patch_core::patch::apply::select_installed_variants;
13-
use socket_patch_core::patch::redirect::upstream::HostedPin;
1413
use socket_patch_core::patch::rollback::{
1514
cannot_rollback_error, rollback_package_patch, verify_file_rollback, RollbackResult,
1615
VerifyRollbackResult, VerifyRollbackStatus,
1716
};
1817
use socket_patch_core::telemetry::{track_patch_rollback_failed, track_patch_rolled_back};
1918
use socket_patch_core::utils::purl::{patch_matches, strip_purl_qualifiers};
19+
use socket_patch_core::patch::redirect::upstream::HostedPin;
2020
use socket_patch_core::vendor::{purl_keys_cover, RevertOpts, VendorState};
2121
use std::collections::{HashMap, HashSet};
2222
use std::path::{Path, PathBuf};
@@ -1026,8 +1026,7 @@ pub(crate) async fn run_hosted_leg(common: &GlobalArgs, pins: &[HostedPin]) -> H
10261026
.iter()
10271027
.map(|(code, detail)| (code.to_string(), detail.clone())),
10281028
);
1029-
out.edited_files
1030-
.extend(outcome.reverted_files.iter().cloned());
1029+
out.edited_files.extend(outcome.reverted_files.iter().cloned());
10311030
let unwound: Vec<_> = vlt_targets
10321031
.into_iter()
10331032
.filter(|t| out.reverted.iter().any(|p| p == &t.purl))
@@ -1158,11 +1157,7 @@ pub async fn run(args: RollbackArgs) -> i32 {
11581157
} else if !args.common.silent {
11591158
println!(
11601159
"{} the pre-v5 hosted ledger {}: no lockfile pins a hosted patch.",
1161-
if args.common.dry_run {
1162-
"Would remove"
1163-
} else {
1164-
"Removed"
1165-
},
1160+
if args.common.dry_run { "Would remove" } else { "Removed" },
11661161
socket_patch_core::patch::redirect::REDIRECT_STATE_REL
11671162
);
11681163
}

‎crates/socket-patch-cli/src/commands/scan/hosted.rs‎

Lines changed: 11 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -934,8 +934,7 @@ pub(crate) async fn run_redirect_selected(
934934
socket_patch_core::utils::fs::read_regular_to_string_sync(path).ok()
935935
})
936936
};
937-
let rewrite_options = || {
938-
RewriteOptions {
937+
let rewrite_options = || RewriteOptions {
939938
dry_run: common.dry_run,
940939
targets_pipenv_lock,
941940
pipenv_major,
@@ -947,7 +946,6 @@ pub(crate) async fn run_redirect_selected(
947946
npm_allow_remote_config: !common.no_npm_allow_remote_config,
948947
npm_outer: &npm_outer,
949948
blocking: true,
950-
}
951949
};
952950
// The rollout gate plans again without its deferred rows: keep what
953951
// the second pass needs.
@@ -2173,19 +2171,13 @@ fn join_names(names: &[String], max: usize) -> String {
21732171
/// artifacts, then verify with `vex`. After a vendored→hosted takeover
21742172
/// (`vendored_removed`) the commit also has to carry the deleted vendored
21752173
/// ledger entries and artifacts.
2176-
fn format_next_steps(
2177-
files: &[String],
2178-
edits: &[socket_patch_core::patch::redirect::FileEdit],
2179-
vendored_removed: bool,
2180-
) -> Vec<String> {
2174+
fn format_next_steps(files: &[String], edits: &[socket_patch_core::patch::redirect::FileEdit], vendored_removed: bool) -> Vec<String> {
21812175
if files.is_empty() && !vendored_removed {
21822176
return Vec::new();
21832177
}
21842178
let mut commit: Vec<String> = Vec::new();
21852179
if vendored_removed {
2186-
commit.push(
2187-
".socket/vendor/ (the removed vendored ledger entries and artifacts)".to_string(),
2188-
);
2180+
commit.push(".socket/vendor/ (the removed vendored ledger entries and artifacts)".to_string());
21892181
}
21902182
commit.extend(files.iter().cloned());
21912183
let npm = files
@@ -4103,43 +4095,19 @@ mod tests {
41034095
use super::npm_allow_remote_one_line;
41044096
let hosts = ["patch.socket.dev"];
41054097
let cases = [
4106-
(
4107-
npm_allow_remote_configured_detail(&hosts, true, false),
4108-
"Note: set",
4109-
),
4110-
(
4111-
npm_allow_remote_configured_detail(&hosts, false, false),
4112-
"Note: set",
4113-
),
4114-
(
4115-
npm_allow_remote_configured_detail(&hosts, true, true),
4116-
"Note: would set",
4117-
),
4118-
(
4119-
npm_allow_remote_already_detail(&hosts),
4120-
"Note: .npmrc already",
4121-
),
4122-
(
4123-
npm_allow_remote_user_set_detail(&hosts, "none"),
4124-
"Warning: npm >=12",
4125-
),
4126-
(
4127-
npm_allow_remote_env_set_detail(&hosts, "npm_config_allow_remote", "none"),
4128-
"Warning: npm >=12",
4129-
),
4098+
(npm_allow_remote_configured_detail(&hosts, true, false), "Note: set"),
4099+
(npm_allow_remote_configured_detail(&hosts, false, false), "Note: set"),
4100+
(npm_allow_remote_configured_detail(&hosts, true, true), "Note: would set"),
4101+
(npm_allow_remote_already_detail(&hosts), "Note: .npmrc already"),
4102+
(npm_allow_remote_user_set_detail(&hosts, "none"), "Warning: npm >=12"),
4103+
(npm_allow_remote_env_set_detail(&hosts, "npm_config_allow_remote", "none"), "Warning: npm >=12"),
41304104
(npm_allow_remote_manual_detail(&hosts), "Warning: npm >=12"),
4131-
(
4132-
npm_allow_remote_unreadable_detail(&hosts, "is a symlink"),
4133-
"Warning: npm >=12",
4134-
),
4105+
(npm_allow_remote_unreadable_detail(&hosts, "is a symlink"), "Warning: npm >=12"),
41354106
];
41364107
for (detail, start) in cases {
41374108
let line = npm_allow_remote_one_line(&detail);
41384109
assert!(line.starts_with(start), "{line}");
4139-
assert!(
4140-
!line.contains('\n') && line.ends_with("(details: --verbose)."),
4141-
"{line}"
4142-
);
4110+
assert!(!line.contains('\n') && line.ends_with("(details: --verbose)."), "{line}");
41434111
}
41444112
}
41454113
}

0 commit comments

Comments
 (0)