|
| 1 | +import subprocess |
| 2 | + |
| 3 | +import pytest |
| 4 | + |
| 5 | +from socketsecurity.config import ( |
| 6 | + MAX_COMMIT_MESSAGE_LENGTH, |
| 7 | + CliConfig, |
| 8 | + truncate_commit_message, |
| 9 | +) |
| 10 | +from socketsecurity.socketcli import apply_git_context |
| 11 | + |
| 12 | + |
| 13 | +def _git(path, *args): |
| 14 | + return subprocess.run( |
| 15 | + ["git", *args], |
| 16 | + cwd=path, |
| 17 | + check=True, |
| 18 | + capture_output=True, |
| 19 | + text=True, |
| 20 | + ).stdout.strip() |
| 21 | + |
| 22 | + |
| 23 | +@pytest.fixture |
| 24 | +def repo_with_large_commit_message(tmp_path): |
| 25 | + """A checkout whose HEAD commit message is far larger than the cap (~14 KB).""" |
| 26 | + path = tmp_path / "repo" |
| 27 | + path.mkdir() |
| 28 | + _git(path, "init", "-b", "main") |
| 29 | + _git(path, "config", "user.name", "Socket Test") |
| 30 | + _git(path, "config", "user.email", "socket@example.com") |
| 31 | + (path / "package.json").write_text("{}\n", encoding="utf-8") |
| 32 | + _git(path, "add", "package.json") |
| 33 | + _git(path, "commit", "-m", "Release notes\n\n" + ("- bumped a dependency\n" * 700)) |
| 34 | + return path |
| 35 | + |
| 36 | + |
| 37 | +class TestTruncateCommitMessage: |
| 38 | + def test_none_passes_through(self): |
| 39 | + assert truncate_commit_message(None) is None |
| 40 | + |
| 41 | + def test_empty_passes_through(self): |
| 42 | + assert truncate_commit_message("") == "" |
| 43 | + |
| 44 | + def test_under_limit_is_unchanged(self): |
| 45 | + msg = "a normal short commit message" |
| 46 | + assert truncate_commit_message(msg) == msg |
| 47 | + |
| 48 | + def test_at_limit_is_unchanged(self): |
| 49 | + msg = "a" * MAX_COMMIT_MESSAGE_LENGTH |
| 50 | + assert truncate_commit_message(msg) == msg |
| 51 | + |
| 52 | + def test_over_limit_is_capped(self): |
| 53 | + assert truncate_commit_message("a" * 14_000) == "a" * MAX_COMMIT_MESSAGE_LENGTH |
| 54 | + |
| 55 | + |
| 56 | +class TestCliConfigInvariant: |
| 57 | + def test_direct_construction_is_capped(self): |
| 58 | + config = CliConfig(api_token="test", repo="widgets", commit_message="a" * 14_000) |
| 59 | + assert config.commit_message == "a" * MAX_COMMIT_MESSAGE_LENGTH |
| 60 | + |
| 61 | + def test_config_file_value_is_capped(self, tmp_path): |
| 62 | + config_file = tmp_path / "socketcli.json" |
| 63 | + config_file.write_text('{"commit_message": "%s"}' % ("a" * 14_000), encoding="utf-8") |
| 64 | + config = CliConfig.from_args(["--api-token", "test", "--config", str(config_file)]) |
| 65 | + assert config.commit_message == "a" * MAX_COMMIT_MESSAGE_LENGTH |
| 66 | + |
| 67 | + |
| 68 | +class TestGitBackfill: |
| 69 | + def test_message_read_from_git_is_capped(self, repo_with_large_commit_message): |
| 70 | + config = CliConfig(api_token="test", repo=None, target_path=str(repo_with_large_commit_message)) |
| 71 | + assert config.commit_message is None |
| 72 | + |
| 73 | + is_repo, git_repo = apply_git_context(config) |
| 74 | + |
| 75 | + assert is_repo is True |
| 76 | + # The repository really does carry an oversized message; the cap is what keeps it |
| 77 | + # out of the full-scan query string. |
| 78 | + assert len(git_repo.commit_message) > 14_000 |
| 79 | + assert len(config.commit_message) == MAX_COMMIT_MESSAGE_LENGTH |
| 80 | + assert config.commit_message == git_repo.commit_message[:MAX_COMMIT_MESSAGE_LENGTH] |
| 81 | + |
| 82 | + def test_explicit_message_is_not_overwritten_by_git(self, repo_with_large_commit_message): |
| 83 | + config = CliConfig( |
| 84 | + api_token="test", |
| 85 | + repo=None, |
| 86 | + target_path=str(repo_with_large_commit_message), |
| 87 | + commit_message="explicit message", |
| 88 | + ) |
| 89 | + |
| 90 | + apply_git_context(config) |
| 91 | + |
| 92 | + assert config.commit_message == "explicit message" |
| 93 | + |
| 94 | + def test_non_repo_path_reports_no_repo(self, tmp_path): |
| 95 | + config = CliConfig(api_token="test", repo=None, target_path=str(tmp_path)) |
| 96 | + |
| 97 | + is_repo, git_repo = apply_git_context(config) |
| 98 | + |
| 99 | + assert is_repo is False |
| 100 | + assert git_repo is None |
| 101 | + assert config.ignore_commit_files is True |
0 commit comments