-
Notifications
You must be signed in to change notification settings - Fork 9
DAT-175 filter out ignored alerts #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.43.dev1Docker image: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
nolanlawson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I'd like @dacoburn to take a look too
dacoburn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the need for pulling/checking the security policy completely and relying on the alert action status instead. Should reduce errors
Slack alerts are being sent for triaged alerts.
Root Cause
I think the root cause is that the Python CLI overrides the alert triage actions with the security policy. In socketsecurity/core/init.py, the add_package_alerts_to_collection method always uses the security policy action and ignores the action field.
Fix
From my understanding I think this can be fixed by using the
actionfield when it's available. Maybe something likePublic Changelog
N/A