-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Description
The type information of AWSOptions has not changed since using aws-sdk v2.
Therefore, this type needs to be changed to aws-sdk v3 compatible type.
Specifically, the differences are as follows.
aws-sdk v2 compatible type (current type)
export type AWSOptions = {
accessKeyId?: string;
secretAccessKey?: string;
region: string;
bucket: string;
expires?: number;
}aws-sdk v3 compatible type
export type AWSOptions = {
credentials?: {
accessKeyId: string;
secretAccessKey: string;
},
region: string;
bucket: string;
expires?: number;
}In the current implementation, the AWSOptions information is passed as is to the S3 Client option information.
So If it do not change the implementation of AWSProvider, it will need to change the AWSOptions type information.
abbasharoon and JuyeopJangthiago-silva-tech
Metadata
Metadata
Assignees
Labels
No labels