From 3bed4874a10e4c9ec25af4848c881abb92c0ad76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Leite?= Date: Sat, 13 Jun 2026 21:50:53 -0300 Subject: [PATCH] fix: wrap slow dt2() examples in \donttest to clear CRAN timing NOTE CRAN's incoming pre-test for 0.1.2 flagged one NOTE on r-devel-windows: the dt2() examples ran in 19.01s elapsed (> 10s). Wrap all but one minimal dt2() example in \donttest{} (in dt2() and dt2_theme()), bringing the timed example run to ~0.5s. No code changed. Bump Date to 2026-06-14 and note the resubmission in cran-comments.md. Co-Authored-By: Claude Opus 4.8 (1M context) --- DESCRIPTION | 2 +- R/dt2.R | 4 ++++ cran-comments.md | 8 ++++++++ man/dt2.Rd | 2 ++ man/dt2_theme.Rd | 2 ++ 5 files changed, 17 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index a8bd12f..ab955e2 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -2,7 +2,7 @@ Package: DT2 Type: Package Title: 'DataTables' 2.x for R Version: 0.1.2 -Date: 2026-06-13 +Date: 2026-06-14 Authors@R: c( person("Andre", "Leite", email = "leite@castlab.org", role = c("aut", "cre")), person("Marcos", "Wasilew", email = "marcos.wasilew@gmail.com", role = "aut"), diff --git a/R/dt2.R b/R/dt2.R index 99e92f0..5239822 100644 --- a/R/dt2.R +++ b/R/dt2.R @@ -56,8 +56,10 @@ #' @examples #' # Create and reuse #' my_theme <- dt2_theme("clean", compact = TRUE) +#' \donttest{ #' dt2(iris, theme = my_theme) #' dt2(mtcars, theme = my_theme) +#' } #' #' # Custom button style #' dt2_theme("default", button_class = "btn btn-sm btn-primary") @@ -161,6 +163,7 @@ print.dt2_theme <- function(x, ...) { #' # Just works — beautiful defaults #' dt2(iris) #' +#' \donttest{ #' # Override style inline #' dt2(iris, striped = FALSE) #' dt2(iris, font_scale = 0.85, compact = FALSE) @@ -204,6 +207,7 @@ print.dt2_theme <- function(x, ...) { #' buttons = list("copy", "csv", "excel"), #' layout = list(topEnd = "buttons") #' )) +#' } dt2 <- function(data, # ---- styling ---- theme = "default", diff --git a/cran-comments.md b/cran-comments.md index 0294f22..87ccc13 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,3 +1,11 @@ +## Resubmission + +This is a resubmission of 0.1.2. The previous submission was flagged by the +incoming pre-test with one NOTE on r-devel-windows: the `dt2()` examples ran +in > 10s elapsed. I have wrapped all but one minimal `dt2()` example in +`\donttest{}` (in `dt2()` and `dt2_theme()`), so the timed example run is now +well under the threshold. No code was changed. + ## Update This is a minor update (0.1.2) of a package already on CRAN. It fixes two diff --git a/man/dt2.Rd b/man/dt2.Rd index 474b0b6..dc6ae82 100644 --- a/man/dt2.Rd +++ b/man/dt2.Rd @@ -75,6 +75,7 @@ JavaScript API). The two concerns are cleanly separated. # Just works — beautiful defaults dt2(iris) +\donttest{ # Override style inline dt2(iris, striped = FALSE) dt2(iris, font_scale = 0.85, compact = FALSE) @@ -119,3 +120,4 @@ dt2(mtcars, layout = list(topEnd = "buttons") )) } +} diff --git a/man/dt2_theme.Rd b/man/dt2_theme.Rd index 1942998..8338338 100644 --- a/man/dt2_theme.Rd +++ b/man/dt2_theme.Rd @@ -46,8 +46,10 @@ For quick one-off styling, you can also pass arguments directly to \examples{ # Create and reuse my_theme <- dt2_theme("clean", compact = TRUE) +\donttest{ dt2(iris, theme = my_theme) dt2(mtcars, theme = my_theme) +} # Custom button style dt2_theme("default", button_class = "btn btn-sm btn-primary")