Cannot obtain Ethernet MAC address

[nonew]

Dear owner,
In my Windows 8 pro 32-bit machine, it is returning MAC address of Mobile broadband instead of Ethernet connection. Although UuidCreateSequential() function is returning RPC_S_OK. Do you know the reason?

[T-Rex]

Hello. According to docs, RPC_S_OK means that call was successful. Windows places the IP address of the first available network adapter into the UUID (but your computer might contain several adapters). So, in your case it uses the address of Mobile broadband adapter. You can change the logic and use this approach if you want. And if it works for you then submit a pull request ;)

[nonew]

Dear T-Rex,
Your link generate IP address instead of MAC address. I found a useful link(http://www.niris.co.uk/mac.html) list up several methods to get the MAC Address of a machine. And I managed to call GetAdaptersInfo() to obtain MAC address of Ethernet adapter, which is similar to the WinCE method you implemented. Here is my code:
inline long MACAddressUtility::GetMACAddressMSW(unsigned char * result)
{
#if defined(UNDER_CE)
//...
#else
PIP_ADAPTER_INFO IpAdapterInfo = NULL;
PIP_ADAPTER_INFO currAdapterInfo;
ULONG cbIpAdapterInfo;
char AdapterMac[MAX_PATH];
//
// Call GetAdaptersInfo to get a list of network device information.
// Use this to obtain mac address and filter for ethernet adapter.
//
cbIpAdapterInfo = 0;
if (GetAdaptersInfo(NULL, &cbIpAdapterInfo) != ERROR_BUFFER_OVERFLOW) {
goto clean;
}
IpAdapterInfo = (PIP_ADAPTER_INFO)malloc(cbIpAdapterInfo);
if (!IpAdapterInfo) {
goto clean;
}
if (GetAdaptersInfo(IpAdapterInfo, &cbIpAdapterInfo) != NO_ERROR) {
goto clean;
}
currAdapterInfo = IpAdapterInfo;
while (currAdapterInfo) {
sprintf(AdapterMac, "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x",
currAdapterInfo->Address[0], currAdapterInfo->Address[1], currAdapterInfo->Address[2],
currAdapterInfo->Address[3], currAdapterInfo->Address[4], currAdapterInfo->Address[5]);
if (MIB_IF_TYPE_ETHERNET == currAdapterInfo->Type && strstr(currAdapterInfo->Description, "PCI") > 0) {
memcpy(result, (char*)(currAdapterInfo->Address), 6);
break;
}
currAdapterInfo = currAdapterInfo->Next;
}
clean:
if (IpAdapterInfo) {
free(IpAdapterInfo);
}
#endif
return 0;
}

[T-Rex]

Hello. Indeed, the link I posted is for IP address, sorry. As for your code, try to avoid using goto operator by using smth like this:

do
{
    if(<some-error-condition-here>) break;
    ...
    if(<some-error-condition-here>) break;
    ...
    // Put some logic here if everything is OK
}
while(false);

// Here you can put your cleanup code.

---

I will try the proposed solution, if works then will push the new version