From ae862eabf919cf5f4899afcf58f0370f17b603ca Mon Sep 17 00:00:00 2001 From: Ryan Barlow <7389646+ryanbarlow97@users.noreply.github.com> Date: Thu, 1 Oct 2026 11:19:33 +0000 Subject: [PATCH] fix: reword player messages in character Replace out-of-character wording in gameplay messages (permissions, containers, entities, chunks, plugin tags) with in-world phrasing. Staff commands, usage help and setup errors keep their plain wording. Co-Authored-By: Claude Opus 5.5 (1M context) --- .../advancedcrafting/managers/CraftingManager.java | 8 ++++---- .../advancedcrafting/utils/ProfessionPermissions.java | 6 +++--- src/main/resources/config.yml | 8 ++++---- .../advancedcrafting/AlloyManagerCoverageTest.java | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/main/java/net/tfminecraft/advancedcrafting/managers/CraftingManager.java b/src/main/java/net/tfminecraft/advancedcrafting/managers/CraftingManager.java index e20f523..300ab73 100644 --- a/src/main/java/net/tfminecraft/advancedcrafting/managers/CraftingManager.java +++ b/src/main/java/net/tfminecraft/advancedcrafting/managers/CraftingManager.java @@ -220,15 +220,15 @@ public void openStation(PlayerInteractEvent e) { StationFeedback f = station.addMaterial(p, i); switch (f) { case NOT_INGREDIENT: - p.sendMessage("§cThis item cannot be used for crafting"); + p.sendMessage("§cThat is not a material you can work"); p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f); break; case WRONG_TYPE: - p.sendMessage("§cThis item type is not needed for the recipe"); + p.sendMessage("§cThis recipe does not call for that material"); p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f); break; case CAPACITY: - p.sendMessage("§cYou already have the needed amount of this type"); + p.sendMessage("§cThe piece already has enough of that material"); p.playSound(p.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 1f, 0.5f); break; case NO_PERMS: @@ -354,7 +354,7 @@ public void applyHit(PlayerInteractEvent e) { p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f); break; case WRONG_TYPE: - p.sendMessage("§cThis item cannot be used for crafting hits"); + p.sendMessage("§cYou cannot work the piece with that tool"); p.playSound(p.getLocation(), Sound.ENTITY_VILLAGER_NO, 1f, 1f); break; case NONE: diff --git a/src/main/java/net/tfminecraft/advancedcrafting/utils/ProfessionPermissions.java b/src/main/java/net/tfminecraft/advancedcrafting/utils/ProfessionPermissions.java index 38c0f02..c9e50d1 100644 --- a/src/main/java/net/tfminecraft/advancedcrafting/utils/ProfessionPermissions.java +++ b/src/main/java/net/tfminecraft/advancedcrafting/utils/ProfessionPermissions.java @@ -123,14 +123,14 @@ public static int resolveAlloyTier(String alloyId) { } public static String missingIngredientPermissionMessage(String permissionKey) { - return "§cYou need the " + getDisplayName(permissionKey) + " permission to use this material."; + return "§cYou are not skilled enough in " + getDisplayName(permissionKey) + " to work this material."; } public static String missingNamespaceMessage(String namespace) { - return "§cYou need at least one of the " + getDisplayName(namespace) + " permissions."; + return "§cYou are not skilled enough in " + getDisplayName(namespace) + " to make this."; } public static String missingExactTierMessage(String namespace, int tier) { - return "§cYou need the " + getDisplayName(namespace) + " tier " + tier + " permission to use this material."; + return "§cYour " + getDisplayName(namespace) + " training does not extend to tier " + tier + " materials."; } } diff --git a/src/main/resources/config.yml b/src/main/resources/config.yml index 6e96fe2..ca3010e 100644 --- a/src/main/resources/config.yml +++ b/src/main/resources/config.yml @@ -83,11 +83,11 @@ permission-namespaces: ingredient: display: "#e6a817Ingredient" iron_smith: - display: "#e6a817Iron_Smith" + display: "#e6a817Iron Smithing" steel_smith: - display: "#e6a817Steel_Smith" + display: "#e6a817Steel Smithing" abyssalite_smith: - display: "#e6a817Abyssalite_Smith" + display: "#e6a817Abyssalite Smithing" mythril_smith: - display: "#e6a817Mythril_Smith" + display: "#e6a817Mythril Smithing" diff --git a/src/test/java/net/tfminecraft/advancedcrafting/AlloyManagerCoverageTest.java b/src/test/java/net/tfminecraft/advancedcrafting/AlloyManagerCoverageTest.java index 0aa4f70..ebe2aa4 100644 --- a/src/test/java/net/tfminecraft/advancedcrafting/AlloyManagerCoverageTest.java +++ b/src/test/java/net/tfminecraft/advancedcrafting/AlloyManagerCoverageTest.java @@ -83,7 +83,7 @@ void interactionValidatesStructureMaterialPermissionsCapacityAndCooldown() throw assertFalse(m.hasStation(b.getLocation())); clearCooldown(m); m.addIngredient(event(p, b)); - assertTrue(p.nextMessage().contains("permission")); + assertTrue(p.nextMessage().contains("not skilled enough")); p.setOp(true); clearCooldown(m); p.getInventory().setItemInMainHand(base.build());