Skip to content

render_functions.py : get_names_at_location Capitalization #43

Description

@rinqtmith

In the function, names is capitalized after joined together. If there are two entities there only first letter is capitalized.
It is better to capitalize then join them.

From: (Player remains of troll)

names = ", ".join(
        entity.name for entity in game_map.entities if entity.x == x and entity.y == y
    )

    return names.capitalize()

To: (Player Remains of troll)

names = ", ".join(entity.name.capitalize() for entity in game_map.entities
                      if entity.x == x and entity.y == y)

    return names

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions