From d943464c6b5bdd1a843d78c47c65d11a80affbda Mon Sep 17 00:00:00 2001 From: Justin White Date: Thu, 30 Oct 2025 12:35:23 -0500 Subject: [PATCH 1/2] fix: customTrigger getting defaulted to a value even when not passed (#252) --- packages/solid-devtools/src/core.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/solid-devtools/src/core.tsx b/packages/solid-devtools/src/core.tsx index 539ad54d..5b2938ef 100644 --- a/packages/solid-devtools/src/core.tsx +++ b/packages/solid-devtools/src/core.tsx @@ -148,7 +148,9 @@ export default function SolidDevtoolsCore({ new TanStackDevtoolsCore({ config: { ...config, - customTrigger: (el, props) => convertTrigger(el, props), + customTrigger: config?.customTrigger + ? (el, props) => convertTrigger(el, props) + : undefined, }, eventBusConfig, plugins: pluginsMap(), @@ -160,7 +162,9 @@ export default function SolidDevtoolsCore({ devtools().setConfig({ config: { ...config, - customTrigger: (el, props) => convertTrigger(el, props), + customTrigger: config?.customTrigger + ? (el, props) => convertTrigger(el, props) + : undefined, }, }) }) From 8d47cc080764a03fa94799bbfccd126777663007 Mon Sep 17 00:00:00 2001 From: Justin White Date: Thu, 30 Oct 2025 12:50:25 -0500 Subject: [PATCH 2/2] Generate changeset --- .changeset/nice-files-stick.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nice-files-stick.md diff --git a/.changeset/nice-files-stick.md b/.changeset/nice-files-stick.md new file mode 100644 index 00000000..317191da --- /dev/null +++ b/.changeset/nice-files-stick.md @@ -0,0 +1,5 @@ +--- +'@tanstack/solid-devtools': patch +--- + +Fixed customTrigger causing empty button when not passed