Check fail in STM32Cube 'challenge' project

[JordiiQueralto]

Hi Albert,

I have configured Timer 2 Channel 1 as Output Compare with Toggle on Match in CubeMX, so I am using HAL_TIM_OC_Stop as per the HAL documentation. However, the CI check fails with an implicit declaration error on HAL_TIM_OC_Stop and suggests using HAL_TIM_PWM_Stop instead, which does not make much sense to me given the Output Compare configuration. I have also tested the code on the board and it works correctly.

[TheAlbertDev]

Hey! I've found the issue. I've already implemented a fix, but I'll test it tonight to make sure it works. In the meantime, could you please create the corresponding issue in this repo so I can link it to the fix? Thanks!

[TheAlbertDev]

I've tested the patch and all tests are passing. I'm waiting for you to create the issue so I can link it to the fix and push it. Thanks!

[JordiiQueralto]

I already opened these issues.

[TheAlbertDev]

Just a heads-up: issues should be created using the button in the main README so they're created in the correct repository. This time I've recreated them in the right repo and closed the original ones.

From now on, please use that button to make sure everything stays organized. Thanks! 😊

[TheAlbertDev]

Hey! I've pushed the patch. To incorporate it into your repo, run the following commands:

git switch main
git pull
git remote add upstream-2 https://github.com/TheAlbertDev/masb-course-timers.git
git fetch upstream-2
git cherry-pick cfd06da
git push
git switch stm32cube-challenge
git rebase main
git push --force

Here's what each command does:

1. Get your main branch up to date

git switch main
git pull

Switch to your main branch and pull the latest changes from your remote.

2. Add the course repo as a second remote and fetch it

git remote add upstream-2 https://github.com/TheAlbertDev/masb-course-timers.git
git fetch upstream-2

This registers the course repo as a new remote called upstream-2 and downloads its history locally — without modifying your branches.

3. Cherry-pick the patch commit

git cherry-pick cfd06da

This takes the specific commit with the fix (cfd06da) from the course repo and applies it on top of your main branch.

gitGraph
   commit id: "..."
   commit id: "your last commit"
   commit id: "cfd06da (patch)" type: HIGHLIGHT

Loading

4. Push main

git push

Push your updated main (now including the patch) to your remote.

5. Rebase your working branch on top of the updated main

git switch stm32cube-challenge
git rebase main
git push --force

Switch to your working branch (stm32cube-challenge), rebase it on top of the updated main so it includes the patch, and force-push to update the remote.

gitGraph
   commit id: "..."
   commit id: "your last commit"
   commit id: "cfd06da (patch)" type: HIGHLIGHT
   branch stm32cube-challenge
   commit id: "your work (rebased)"

Loading

Let me know if you run into any issues! 💪

[JordiiQueralto]

Hey Albert! Sorry for opening the issue in a wrong place and thanks for the response. All works correctly now.