Skip to content

Commit 370327f

Browse files
committed
Fix integer overflow in AbsoluteValue.getAbsValue for Integer.MIN_VALUE
1 parent c99b056 commit 370327f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/main/java/com/thealgorithms/maths/AbsoluteValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ private AbsoluteValue() {
1010
* @param number The number to be transformed
1111
* @return The absolute value of the {@code number}
1212
*/
13-
public static int getAbsValue(int number) {
13+
public static long getAbsValue(long number) {
1414
return Math.abs(number);
1515
}
1616
}

src/test/java/com/thealgorithms/maths/AbsoluteValueTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ void testNegativeNumbers() {
3434

3535
@Test
3636
void testMinIntEdgeCase() {
37-
assertEquals(Integer.MIN_VALUE, AbsoluteValue.getAbsValue(Integer.MIN_VALUE));
37+
assertEquals(2147483648L, AbsoluteValue.getAbsValue(Integer.MIN_VALUE));
3838
}
3939
}

0 commit comments

Comments
 (0)