From f29fd8b82dd53d7fb9f716e02f771dcb0f125dca Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Thu, 18 Jun 2026 15:28:09 +0200 Subject: [PATCH 1/2] Makefile: add github workflow checking This change adds linting of the github workflow file(s) using the actionlint tool. For developer convenience, this can be invoked as `make lint.workflows`. Additionally, ome make target dependencies are slightly rearrangrd so that, for example lint and check run workflow linting. Signed-off-by: Michael Adam --- Makefile | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 75c892a..a565688 100644 --- a/Makefile +++ b/Makefile @@ -4,6 +4,7 @@ TARGET := easyshift CHECKMAKE := go run github.com/checkmake/checkmake/cmd/checkmake@v0.3.2 GOLANGCI_LINT := go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1 +ACTIONLINT := go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 .DEFAULT_GOAL := build @@ -11,7 +12,7 @@ GOLANGCI_LINT := go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.5 .PHONY: check -check: lint build test +check: lint.light build test .PHONY: lint.go.vet lint.go.vet: @@ -38,6 +39,9 @@ fix.go.fmt: # fix go formatting (if needed) .PHONY: lint.go.light lint.go.light: lint.go.vet lint.go.fmt + + + .PHONY: test test: lint.go.light ## run unit tests @go test -count=1 ./... @@ -58,9 +62,21 @@ lint.go.full: lint.go.light lint.go.golangci lint.make: @$(CHECKMAKE) $(MK_SOURCE) +.PHONY: lint.light + +lint.light: lint.make lint.workflows lint.go.light + + .PHONY: lint -lint: lint.make lint.go.light +lint: lint.make lint.workflows lint.go.full + +.PHONY: lint.workflows + +lint.workflows: ## lint the GitHub workflow files + @echo "linting GitHub workflows..." + @$(ACTIONLINT) -color + @echo "workflows are good." From 3f5fa144e60a2047becd84576f134c1e2a65dc21 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Thu, 18 Jun 2026 15:33:35 +0200 Subject: [PATCH 2/2] Makefile make the lint.make target more verbose This change adds some informational messages to Makefile linting with `make lint.make` Signed-off-by: Michael Adam --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index a565688..e6d725d 100644 --- a/Makefile +++ b/Makefile @@ -60,7 +60,9 @@ lint.go.full: lint.go.light lint.go.golangci .PHONY: lint.make lint.make: + @echo "linting the Makefile..." @$(CHECKMAKE) $(MK_SOURCE) + @echo "the Makefile is OK." .PHONY: lint.light