From 2fad665feb9a2346d75fe473dfbe21e51fe4f1c2 Mon Sep 17 00:00:00 2001 From: fylorn <249551762+fylorn@users.noreply.github.com> Date: Sat, 3 Oct 2026 03:19:26 +0800 Subject: [PATCH] Allow clippy::double_must_use on the async_trait BlobStore Clippy 1.99 added double_must_use, and it fires on the methods async_trait generates for BlobStore: each is marked #[must_use] and returns a boxed future that is must-use already. CI has failed on it since 2026-10-02. Co-Authored-By: Claude Opus 5.5 --- crates/common/src/blob_store.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/common/src/blob_store.rs b/crates/common/src/blob_store.rs index cb5cb47d..5211d7a8 100644 --- a/crates/common/src/blob_store.rs +++ b/crates/common/src/blob_store.rs @@ -100,6 +100,10 @@ pub struct BlobKeyHint<'a> { pub field: &'a str, } +// `async_trait` marks every generated method `#[must_use]`, and the boxed +// future it returns is already must-use; clippy 1.99's `double_must_use` +// flags that generated code, which there is no way to change from here. +#[allow(clippy::double_must_use)] #[async_trait] pub trait BlobStore: Send + Sync + std::fmt::Debug { /// Whether this store can actually offload. `InlineStore` returns