Continue game manifest and V2 tooling normalization cleanup - PR_26139_021-manifest-tooling-normalization-followup

Author: DavidQ

docs/dev/reports/PR_26139_021-manifest-tooling-normalization-followup_report.md

@@ -0,0 +1,47 @@
+# PR_26139_021 Manifest Tooling Normalization Follow-Up
+
+## Summary
+- Tightened `game.manifest.schema.json` so `tools` only accepts current manifest-owned tool payloads.
+- Removed stale manifest-owned tool payloads from `vector-arcade-sample` and converted its vector geometry to `object-vector-studio-v2.objects[]`.
+- Removed optional Workspace Manager launch entries from manifests that do not have an active `palette-manager-v2` workspace context.
+- Removed remaining active `asset-browser` manifest fallback reads from preview/chrome asset resolution.
+
+## Manifest Decisions
+- Direct-only manifests now keep only `launch.directPath`: AI Target Dummy, Bouncing Ball, Breakout, Pacman, Solar System, Space Duel, Space Invaders, and Vector Arcade Sample.
+- Workspace-capable manifests keep current Workspace Manager V2 paths: Asteroids, Gravity Well, and Pong.
+- `vector-arcade-sample` now uses:
+  - `asset-manager-v2` for the preview asset.
+  - `object-vector-studio-v2` for five converted objects: UI HUD, large obstacle, small obstacle, player, and UI title.
+- Removed from `vector-arcade-sample` because the payloads were stale/non-current manifest ownership:
+  - `sprite-editor`
+  - `tile-map-editor`
+  - `parallax-editor`
+  - `svg-asset-studio`
+  - `preview-generator-tool`
+
+## Schema And Runtime Cleanup
+- `tools/schemas/game.manifest.schema.json` now rejects unknown manifest tool keys instead of accepting arbitrary objects.
+- `palette-manager-v2` is now a first-class game manifest schema property.
+- Workspace Manager V2 now preloads/registers `palette-manager-v2.schema.json` when browser-validating game manifests.
+- `src/engine/runtime/gameImageConvention.js` resolves chrome/preview image assets from Asset Manager V2 only.
+- `games/shared/workspaceGameAssetCatalog.js` resolves manifest asset catalog entries from Asset Manager V2 only.
+- `games/shared/workspaceGameLaunchGuard.js` points to `workspace-manager-v2` and no longer emits the old `mount=game` query.
+
+## Validation
+- PASS: `npm run build:manifest`
+- PASS: `node scripts/validate-json-contracts.mjs --mode=games --details`
+  - `game_manifest_schema_validation: total=11 invalid=0`
+- PASS: manifest normalization audit
+  - every manifest has `asset-manager-v2`
+  - every manifest has exactly one preview role asset and the preview file exists
+  - no stale manifest tool keys remain
+  - no old Workspace Manager manifest launch paths remain
+- PASS: `rg -n '"(asset-browser|primitive-skin-editor|palette-browser|vector-map-editor|preview-generator-tool|sprite-editor|tile-map-editor|parallax-editor|svg-asset-studio)"' games -g 'game.manifest.json'`
+  - no remaining game manifest matches
+- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "discovers Active Game options from selected repo manifests"`
+- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "uses header lifecycle controls and launches tools from fixed Workspace Manager V2 tiles"`
+- PASS: `npx playwright test tests/playwright/games/GameIndexPreviewManifestResolution.spec.mjs --project=playwright --workers=1 --reporter=list`
+- PASS: `git diff --check`
+
+## Full Samples Smoke Test
+- Skipped. This PR is scoped to manifest/tooling normalization plus targeted preview and Workspace Manager validation; it does not broadly change sample loading.

games/AITargetDummy/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "AITargetDummy"
   },
   "launch": {
-    "directPath": "/games/AITargetDummy/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=AITargetDummy&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/AITargetDummy/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/Pacman/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "Pacman"
   },
   "launch": {
-    "directPath": "/games/Pacman/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=Pacman&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/Pacman/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/SolarSystem/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "SolarSystem"
   },
   "launch": {
-    "directPath": "/games/SolarSystem/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=SolarSystem&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/SolarSystem/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/SpaceDuel/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "SpaceDuel"
   },
   "launch": {
-    "directPath": "/games/SpaceDuel/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=SpaceDuel&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/SpaceDuel/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/SpaceInvaders/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "SpaceInvaders"
   },
   "launch": {
-    "directPath": "/games/SpaceInvaders/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=SpaceInvaders&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/SpaceInvaders/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/bouncing-ball/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "Bouncing-ball"
   },
   "launch": {
-    "directPath": "/games/Bouncing-ball/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=Bouncing-ball&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/Bouncing-ball/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/breakout/game.manifest.json

@@ -8,9 +8,7 @@
     "folder": "Breakout"
   },
   "launch": {
-    "directPath": "/games/Breakout/index.html",
-    "workspaceManagerPath": "/tools/Workspace%20Manager/index.html?gameId=Breakout&mount=game",
-    "workspaceManagerOptional": true
+    "directPath": "/games/Breakout/index.html"
   },
   "tools": {
     "asset-manager-v2": {

games/shared/workspaceGameAssetCatalog.js

@@ -230,17 +230,12 @@ function normalizeManifestCatalogPayload(payload) {
     tools?.["asset-manager-v2"]?.assets,
     assetsPath
   );
-  const toolAssetEntries = normalizeCatalogEntries(tools?.["asset-browser"]?.assets);
-  const entries = {
-    ...toolAssetEntries,
-    ...assetManagerEntries
-  };
   const isValidSchema = schema === GAME_MANIFEST_SCHEMA;
   const isValidVersion = Number.isFinite(version) && version >= 1;
   return {
     schema,
     version,
-    entries,
+    entries: assetManagerEntries,
     valid: isValidSchema && isValidVersion
   };
 }

games/shared/workspaceGameLaunchGuard.js

@@ -10,7 +10,7 @@ function resolveWorkspaceHostedContext(normalizedGameId) {
   const hosted = params.get("hosted") === "1";
   const hostToolId = (params.get("hostToolId") || "").trim().toLowerCase();
   const hostContextId = (params.get("hostContextId") || "").trim();
-  if (!hosted || hostToolId !== "workspace-manager" || !hostContextId) {
+  if (!hosted || hostToolId !== "workspace-manager-v2" || !hostContextId) {
     return null;
   }
 
@@ -32,9 +32,8 @@ export function openGameInWorkspaceManager(gameId) {
   if (!normalizedGameId) {
     return false;
   }
-  const redirectUrl = new URL("/tools/Workspace%20Manager/index.html", window.location.origin);
+  const redirectUrl = new URL("/tools/workspace-manager-v2/index.html", window.location.origin);
   redirectUrl.searchParams.set("gameId", normalizedGameId);
-  redirectUrl.searchParams.set("mount", "game");
   window.location.replace(redirectUrl.toString());
   return true;
 }