Remove workspace asset catalog naming residue - PR_26140_084-remove-workspace-asset-catalog-residue

Author: DavidQ

docs/dev/reports/workspace_asset_catalog_residue_cleanup_report.md

@@ -0,0 +1,48 @@
+# PR_26140_084 Workspace Asset Catalog Residue Cleanup Report
+
+## Summary
+- Removed active `workspace.asset-catalog.json` fallback path construction from `tools/shared/platformShell.js`.
+- Changed shared tool hydration to read Asset Manager V2 entries from `game.manifest.json`.
+- Renamed `games/shared/workspaceGameAssetCatalog.js` to `games/shared/gameManifestAssets.js`.
+- Replaced workspace-oriented helper exports with manifest-oriented exports:
+  - `primeGameManifestAssets`
+  - `preloadGameManifestAssets`
+  - `resolveGameManifestAssetPath`
+  - `getGameManifestAssetSourcePath`
+- Updated game and test imports to the renamed manifest asset helper.
+- Updated the metadata sync script to derive asset hints from `game.manifest.json` Asset Manager V2 entries instead of the old workspace asset catalog file.
+
+## Behavior Preservation
+- Runtime asset path resolution still resolves Asteroids audio IDs from `games/Asteroids/game.manifest.json`.
+- Workspace-launched game runtime hydration still primes in-memory asset entries when a hosted game context provides them.
+- No compatibility shim or alias pass-through file was left at the old helper path.
+
+## Scope Boundaries
+- No schema files were changed.
+- No sample JSON files were changed.
+- Historical `docs/pr` references to `workspace.asset-catalog.json` were intentionally left untouched.
+- Existing generated scanner output such as `dupes_called.txt` was not edited.
+
+## Validation
+- Ran targeted syntax/import validation for:
+  - `tools/shared/platformShell.js`
+  - `games/shared/gameManifestAssets.js`
+  - `games/shared/workspaceGameRuntimeHydrator.js`
+  - changed game audio/index files
+  - changed Workspace Manager Playwright test
+  - changed runtime tests
+  - `scripts/sync-tool-hints-from-workspace-manager.mjs`
+- Ran targeted manifest asset resolver validation for Asteroids audio paths.
+- Ran `npm run test:workspace-v2`; all 59 tests passed.
+- Ran `git diff --check`.
+- Confirmed no schema or sample JSON files changed.
+- Confirmed no active JS/MJS references remain to `workspace.asset-catalog.json`.
+- Confirmed no active references remain to:
+  - `workspaceGameAssetCatalog`
+  - `preloadWorkspaceGameAssetCatalog`
+  - `primeWorkspaceGameAssetCatalog`
+  - `resolveWorkspaceGameAssetPath`
+  - `getWorkspaceGameAssetCatalogPath`
+
+## Full Samples Smoke Test
+- Not run. This PR is scoped to manifest asset naming/resolution cleanup and Workspace V2 validation passed.

games/Asteroids/index.js

@@ -12,7 +12,7 @@ import { createNoopDevConsoleIntegration } from "/src/shared/debug/noopDevConsol
 import { asPositiveInteger } from "/src/shared/number/numbers.js";
 import AsteroidsGameScene from "./game/AsteroidsGameScene.js";
 import { loadAsteroidsObjectGeometryFromManifest } from "./game/asteroidsObjectGeometryManifest.js";
-import { preloadWorkspaceGameAssetCatalog } from "../shared/workspaceGameAssetCatalog.js";
+import { preloadGameManifestAssets } from "../shared/gameManifestAssets.js";
 
 export const asteroidFlow = Object.freeze({
   attract: attractFlow,
@@ -162,10 +162,10 @@ export async function bootAsteroids({
       return null;
     }
 
-    stage = "preload-asset-catalog";
+    stage = "preload-manifest-assets";
     traceBoot(stage);
-    await preloadWorkspaceGameAssetCatalog("Asteroids", {
-      catalogPath: ASTEROIDS_MANIFEST_PATH
+    await preloadGameManifestAssets("Asteroids", {
+      manifestPath: ASTEROIDS_MANIFEST_PATH
     });
 
     stage = "load-game-manifest";

games/Asteroids/systems/AsteroidsAudio.js

@@ -7,7 +7,7 @@ AsteroidsAudio.js
 import GaplessLoopPlayer from '/src/engine/audio/GaplessLoopPlayer.js';
 import HtmlAudioMediaBackend from '/src/engine/audio/HtmlAudioMediaBackend.js';
 import MediaTrackService from '/src/engine/audio/MediaTrackService.js';
-import { resolveWorkspaceGameAssetPath } from '../../shared/workspaceGameAssetCatalog.js';
+import { resolveGameManifestAssetPath } from '../../shared/gameManifestAssets.js';
 
 const ASTEROIDS_GAME_ID = "Asteroids";
 const ASTEROIDS_AUDIO_ASSET_IDS = Object.freeze({
@@ -38,7 +38,7 @@ export default class AsteroidsAudio {
   }
 
   resolveAudioPath(assetId) {
-    return resolveWorkspaceGameAssetPath(ASTEROIDS_GAME_ID, assetId);
+    return resolveGameManifestAssetPath(ASTEROIDS_GAME_ID, assetId);
   }
 
   ensureInitialized() {

games/SpaceDuel/game/SoundController.js

@@ -4,7 +4,7 @@ David Quesenberry
 03/25/2026
 SoundController.js
 */
-import { resolveWorkspaceGameAssetPath } from "../../shared/workspaceGameAssetCatalog.js";
+import { resolveGameManifestAssetPath } from "../../shared/gameManifestAssets.js";
 
 const SPACE_DUEL_GAME_ID = "SpaceDuel";
 const EFFECT_ASSET_IDS = Object.freeze({
@@ -31,7 +31,7 @@ export default class SoundController {
     if (!assetId) {
       return "";
     }
-    return resolveWorkspaceGameAssetPath(SPACE_DUEL_GAME_ID, assetId);
+    return resolveGameManifestAssetPath(SPACE_DUEL_GAME_ID, assetId);
   }
 
   play(effectId, { volume = 0.42 } = {}) {

games/SpaceInvaders/game/SpaceInvadersAudio.js

@@ -4,7 +4,7 @@ David Quesenberry
 03/24/2026
 SpaceInvadersAudio.js
 */
-import { resolveWorkspaceGameAssetPath } from "../../shared/workspaceGameAssetCatalog.js";
+import { resolveGameManifestAssetPath } from "../../shared/gameManifestAssets.js";
 
 const SPACE_INVADERS_GAME_ID = "SpaceInvaders";
 const EFFECT_ASSET_IDS = Object.freeze({
@@ -33,7 +33,7 @@ export default class SpaceInvadersAudio {
     if (!assetId) {
       return "";
     }
-    return resolveWorkspaceGameAssetPath(SPACE_INVADERS_GAME_ID, assetId);
+    return resolveGameManifestAssetPath(SPACE_INVADERS_GAME_ID, assetId);
   }
 
   setMuted(muted) {