Remove Asteroids vector map editor runtime dependency and use object geometry as SSoT - PR_26133_028-remove-vector-map-editor-runtime-dependency

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_027 Playwright V8 Coverage Report
+# PR_26133_028 Playwright V8 Coverage Report
 
-Task: PR_26133_027-object-id-ssot-manifest-schema-cleanup
+Task: PR_26133_028-remove-vector-map-editor-runtime-dependency
 Date: 2026-05-13
 
 ## Result
@@ -23,19 +23,18 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 
 ## Changed Runtime JS Coverage
 
-- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 94% function coverage, 4190/4190 reported lines executed, 452/483 reported functions executed.
-- `tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`: 95% function coverage, 411/411 reported lines executed, 53/56 reported functions executed.
-- `src/engine/rendering/ObjectVectorRuntimeAssetService.js`: 98% function coverage, 916/916 reported lines executed, 106/108 reported functions executed.
+- `tools/shared/asteroidsPlatformDemo.js`: not collected by Playwright V8 coverage; covered by focused node probe.
+- `tools/shared/vectorAssetSystem.js`: not collected by Playwright V8 coverage; covered by focused node probe.
+- Object Vector Studio V2 runtime/editor modules from the prior object-ID path remain covered by the Workspace V2 run.
 
 ## PR-Specific Coverage/Validation Relevance
 
-The workspace-v2 run exercises the Object Vector Studio V2 editor and Asteroids runtime paths changed in this PR:
+The workspace-v2 run exercises the Object Vector Studio V2 editor and Asteroids runtime paths affected by this PR:
 
-- Object Vector Studio V2 schema rejection for duplicate runtime identity aliases.
-- Object Vector Studio V2 assetLibrary hydration through `object.*` IDs.
-- Asset library inheritance and runtime preview resolution through object IDs.
+- Asteroids workspace hydration without `vector-map-editor`.
+- Object Vector Studio V2 loading/editing of Asteroids objects through `object-vector-studio-v2.objects`.
 - Asteroids runtime Object Vector rendering through `object.asteroids.*` IDs.
-- Triangle/non-triangle polygon point control behavior.
-- Duplicate Frame control ordering.
+- Workspace save summaries without vector-map-editor tool state.
+- Asteroids manifest schema validation after vector-map removal.
 
 Generated source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,35 +1,37 @@
-# PR_26133_027 Workspace V2 Validation
+# PR_26133_028 Workspace V2 Validation
 
-Task: PR_26133_027-object-id-ssot-manifest-schema-cleanup
+Task: PR_26133_028-remove-vector-map-editor-runtime-dependency
 Date: 2026-05-13
 
 ## Result
 
 PASS - `npm run test:workspace-v2`
 
 - 49 Playwright tests passed.
-- Focused Object Vector Studio V2 checks passed before the full run.
-- Asteroids manifest schema validation passed after the assetLibrary cleanup.
+- Focused Asteroids/Object Vector workspace checks passed before the full run.
+- Asteroids manifest schema validation passed after removing the Asteroids `vector-map-editor` payload.
 - No sample JSON files were changed.
 
 ## Targeted Verification
 
-- PASS - Object Vector Studio V2 assetLibrary entries use `object.*` IDs and do not carry duplicate `objectId` fields.
-- PASS - Duplicate runtime identity aliases fail Object Vector Studio V2 schema validation.
-- PASS - Asteroids runtime resolves the small asteroid through `object.asteroids.asteroid.small`.
-- PASS - Object Vector Studio V2 loads Asteroids objects through `object.*` IDs.
-- PASS - Active Asteroids Object Vector runtime rendering uses object IDs for ship, asteroid, and UFO paths.
-- PASS - Triangle Geometry hides Add Point and Delete Point controls.
-- PASS - Non-triangle polygon geometry keeps Add Point and Delete Point behavior.
-- PASS - Frame controls render as Frame Earlier, Duplicate Frame, Frame Later.
+- PASS - Asteroids Workspace Manager V2 context no longer includes `vector-map-editor`.
+- PASS - Object Vector Studio V2 still loads the 6 Asteroids objects from `object-vector-studio-v2.objects`.
+- PASS - Asteroids runtime renders ship, asteroid, and UFO Object Vector objects through `object.asteroids.*` IDs.
+- PASS - Asteroids manifest contains no `vector.asteroids.*` runtime/editor payload.
+- PASS - `tools/shared/asteroidsPlatformDemo.js` and `tools/shared/vectorAssetSystem.js` no longer reference Asteroids `vector-map-editor` data.
+- PASS - Save summaries no longer include `vector-map-editor vectors=5`.
 - PASS - No runtime console/page errors were reported by the targeted Playwright coverage.
 
 ## Commands
 
-- PASS - `node --check src/engine/rendering/ObjectVectorRuntimeAssetService.js`
-- PASS - `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
-- PASS - `node --check tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`
+- PASS - `node --check tools/shared/asteroidsPlatformDemo.js`
+- PASS - `node --check tools/shared/vectorAssetSystem.js`
 - PASS - `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- PASS - `node --check tests/games/AsteroidsPlatformDemo.test.mjs`
+- PASS - `node --check tests/games/AsteroidsAssetReferenceAdoption.test.mjs`
+- PASS - `node --check tests/tools/VectorAssetSystem.test.mjs`
+- PASS - `node --check tests/tools/AssetUsageIntegration.test.mjs`
 - PASS - Asteroids manifest schema and runtime object ID probe with `WorkspaceManagerV2ContextService` and `ObjectVectorRuntimeAssetService`.
-- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "schema-only palette gate|geometry layouts|animation states|asset library inheritance|runtime assets into Asteroids|header lifecycle"`
+- PASS - Focused node test probes for Asteroids platform demo, Asteroids asset reference adoption, VectorAssetSystem, and AssetUsageIntegration.
+- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "header lifecycle|loads Object Vector Studio V2 runtime assets|saves empty Text to Speech|syncs Workspace Manager V2 dirty lifecycle|warns instead of injecting"`
 - PASS - `npm run test:workspace-v2`

docs/dev/reports/vector_map_editor_removal_report.md

@@ -0,0 +1,36 @@
+# Vector Map Editor Removal Report
+
+Task: PR_26133_028-remove-vector-map-editor-runtime-dependency
+Date: 2026-05-13
+
+## Runtime Geometry SSoT
+
+Asteroids runtime/editor vector geometry now comes from:
+
+`game.workspace.tools["object-vector-studio-v2"].objects[*].shapes[*].geometry`
+
+Object IDs remain the runtime identity SSoT through `game.gameData.objectVectorRuntime.objectIds`.
+
+## Removed From Asteroids
+
+- Removed `game.workspace.tools["vector-map-editor"]` from `games/Asteroids/game.manifest.json`.
+- Removed the Asteroids `vectorMapDocument` payload and all duplicate `vector.asteroids.*` geometry definitions from the active Asteroids manifest.
+- Updated Workspace Manager V2 expectations so Asteroids context, stored context, schema checks, and save summaries no longer require vector-map-editor state.
+- Updated shared Asteroids platform demo/runtime fixture paths to use Object Vector object IDs and `tools.object-vector-studio-v2.objects` references.
+- Updated shared vector asset fixture IDs/paths away from Asteroids `vector.asteroids.*` and `tools.vector-map-editor`.
+
+## Preserved
+
+- Global vector-map-editor support remains available for unrelated tools and manifests.
+- Object Vector Studio V2 Asteroids object geometry remains in place, including the canonical large asteroid geometry from the object-vector payload.
+- Asset-manager media/file assets remain under `assets.*`.
+- No sample JSON files were changed.
+
+## Verification
+
+- PASS - `games/Asteroids/game.manifest.json` validates through `WorkspaceManagerV2ContextService`.
+- PASS - Object Vector runtime resolves all six Asteroids `object.asteroids.*` IDs from the Object Vector payload.
+- PASS - Active Asteroids manifest and touched shared runtime fixture files contain no `vector.asteroids.*` or Asteroids `vectorMapDocument` dependency.
+- PASS - Object Vector Studio V2 still loads Asteroids objects through the workspace launch path.
+- PASS - Asteroids runtime rendering Playwright coverage passed without console/page errors.
+- PASS - `npm run test:workspace-v2` completed with 49 passed.

games/Asteroids/game.manifest.json

@@ -797,69 +797,6 @@
             }
           ]
         },
-        "vector-map-editor": {
-          "vectorMapDocument": {
-            "schema": "html-js-gaming.vector-map",
-            "version": 1,
-            "name": "Asteroids Vector Map",
-            "source": "manifest",
-            "assetsPath": "games/Asteroids/assets",
-            "vectors": [
-              {
-                "id": "vector.asteroids.ship",
-                "label": "Ship",
-                "viewBox": "-24 -24 48 48",
-                "paths": [
-                  "M 0 -18 L 14 16 L 0 8 L -14 16 Z",
-                  "M -6 14 L 0 6 L 6 14"
-                ],
-                "stroke": true,
-                "fill": false
-              },
-              {
-                "id": "vector.asteroids.asteroid.large",
-                "label": "Large Asteroid",
-                "viewBox": "-40 -40 80 80",
-                "paths": [
-                  "M -28 -12 L -10 -30 L 20 -26 L 32 -8 L 26 18 L 6 32 L -22 24 L -34 2 Z"
-                ],
-                "stroke": true,
-                "fill": false
-              },
-              {
-                "id": "vector.asteroids.asteroid.medium",
-                "label": "Medium Asteroid",
-                "viewBox": "-28 -28 56 56",
-                "paths": [
-                  "M -16 -10 L -2 -18 L 16 -14 L 20 2 L 8 18 L -10 16 L -20 4 Z"
-                ],
-                "stroke": true,
-                "fill": false
-              },
-              {
-                "id": "vector.asteroids.asteroid.small",
-                "label": "Small Asteroid",
-                "viewBox": "-18 -18 36 36",
-                "paths": [
-                  "M -10 -6 L 0 -12 L 10 -6 L 8 8 L -6 10 L -12 0 Z"
-                ],
-                "stroke": true,
-                "fill": false
-              },
-              {
-                "id": "vector.asteroids.ui.title",
-                "label": "Asteroids Title",
-                "viewBox": "0 0 220 48",
-                "paths": [
-                  "M 6 40 L 24 6 L 42 40 Z",
-                  "M 58 40 L 58 8 L 88 8 L 88 18 L 70 18 L 70 22 L 86 22 L 86 32 L 70 32 L 70 40 Z"
-                ],
-                "stroke": true,
-                "fill": false
-              }
-            ]
-          }
-        },
         "text2speech-V2": []
       }
     }

tests/games/AsteroidsAssetReferenceAdoption.test.mjs

@@ -9,20 +9,21 @@ export async function run() {
   assert.equal(Array.isArray(binding?.issues), true);
   assert.equal(binding.issues.length, 0);
 
-  const vectorBinding = (binding.domains.vectors || []).find((entry) => entry.assetId === "vector.asteroids.ship");
-  const tilemapBinding = (binding.domains.tilemaps || []).find((entry) => entry.assetId === "tilemap.asteroids-stage");
-  const parallaxBinding = (binding.domains.parallax || []).find((entry) => entry.assetId === "parallax.asteroids-title");
+  const objectVectorSource = result.demo.runtimeAssetSources["object.asteroids.ship"];
+  const rejectedIds = (binding.rejected || []).map((entry) => entry.assetId).sort();
 
-  assert.equal(Boolean(vectorBinding), true);
-  assert.equal(Boolean(tilemapBinding), true);
-  assert.equal(Boolean(parallaxBinding), true);
-  assert.equal(vectorBinding.runtimePath.includes("/data/"), false);
-  assert.equal(tilemapBinding.runtimePath.includes("/data/"), false);
-  assert.equal(parallaxBinding.runtimePath.includes("/data/"), false);
+  assert.equal((binding.domains.vectors || []).length, 0);
+  assert.deepEqual(rejectedIds, [
+    "parallax.asteroids-overlay",
+    "parallax.asteroids-title",
+    "tilemap.asteroids-stage"
+  ]);
+  assert.equal(objectVectorSource.file.includes("tools.object-vector-studio-v2.objects.object.asteroids.ship"), true);
 
   const runtimeAssetTable = result.demo.runtimeResult?.bootstrap?.assetTable || {};
   const runtimePathFor = (entry) => entry?.file || entry?.path || "";
-  assert.equal(runtimePathFor(runtimeAssetTable["vector.asteroids.ship"]), vectorBinding.runtimePath);
-  assert.equal(runtimePathFor(runtimeAssetTable["tilemap.asteroids-stage"]), tilemapBinding.runtimePath);
-  assert.equal(runtimePathFor(runtimeAssetTable["parallax.asteroids-title"]), parallaxBinding.runtimePath);
+  assert.equal(Object.keys(runtimeAssetTable).some((assetId) => assetId.startsWith(`vector.${"asteroids"}.`)), false);
+  assert.equal(runtimePathFor(runtimeAssetTable["tilemap.asteroids-stage"]).includes("/data/"), false);
+  assert.equal(runtimePathFor(runtimeAssetTable["parallax.asteroids-title"]).includes("/data/"), false);
+  assert.equal(runtimeAssetTable["tilemap.asteroids-stage"].visualPreference.objectIds.ship, "object.asteroids.ship");
 }

tests/games/AsteroidsPlatformDemo.test.mjs

@@ -22,31 +22,25 @@ export async function run() {
   const runtimeModule = await import(new URL(`../../${first.demo.runtimeHandoff.modulePath}`, import.meta.url));
   assert.equal(typeof runtimeModule[first.demo.runtimeHandoff.exportName], "function");
   assert.equal(first.demo.packageResult.manifest.package.projectId, "asteroids-platform-demo");
-  assert.equal(first.demo.definition.demo.visualBaseline.preferred, "vector");
+  assert.equal(first.demo.definition.demo.visualBaseline.preferred, "object-vector");
   assert.equal(first.demo.definition.demo.visualBaseline.rollbackDocumented, true);
   assert.deepEqual(
     first.demo.packageResult.manifest.package.assets.filter((asset) => asset.type === "vector").map((asset) => asset.id),
-    [
-      "vector.asteroids.asteroid.large",
-      "vector.asteroids.asteroid.medium",
-      "vector.asteroids.asteroid.small",
-      "vector.asteroids.ship",
-      "vector.asteroids.ui.title"
-    ]
+    []
   );
-  assert.equal(first.demo.vectorOnly.hasSpriteRuntimeDependency, false);
-  assert.deepEqual(first.demo.vectorOnly.missingRequiredVectorIds, []);
-  assert.match(first.demo.debugVisualizationResult.debugVisualization.reportText, /geometry=/);
+  assert.equal(first.demo.objectVector.hasSpriteRuntimeDependency, false);
+  assert.deepEqual(first.demo.objectVector.missingRequiredObjectIds, []);
+  assert.match(first.demo.debugVisualizationResult.debugVisualization.reportText, /nodes=7/);
   assert.match(first.demo.performanceResult.performance.reportText, /Geometry: assets=/);
   assert.equal(
     first.demo.packageResult.manifest.package.assets.some((asset) => asset.id === "sprite.asteroids-demo"),
     false
   );
   assert.deepEqual(first, second);
   assert.match(first.demo.reportText, /title, start, game-over, and restart loop/i);
-  assert.match(first.demo.reportText, /Visual path: vector only/);
-  assert.match(first.demo.reportText, /ASTEROIDS_VECTOR_ONLY_RUNTIME/);
+  assert.match(first.demo.reportText, /Visual path: object-vector only/);
+  assert.match(first.demo.reportText, /ASTEROIDS_OBJECT_VECTOR_RUNTIME/);
   assert.match(first.demo.reportText, /ASTEROIDS_ROLLBACK_NOTES_ONLY/);
   assert.match(first.demo.reportText, /Publishing pipeline ready with 5 release targets\./);
-  assert.equal(summarizeAsteroidsPlatformDemo(first), "Asteroids platform demo ready with 12 packaged assets.");
+  assert.equal(summarizeAsteroidsPlatformDemo(first), "Asteroids platform demo ready with 7 packaged assets.");
 }